Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit instance groups #7767

Closed
nixocio opened this issue Jul 29, 2020 · 1 comment
Closed

Edit instance groups #7767

nixocio opened this issue Jul 29, 2020 · 1 comment
Assignees
Labels
type:feature prioritized on a feature board

Comments

@nixocio
Copy link
Contributor

nixocio commented Jul 29, 2020

ISSUE TYPE
  • Feature Idea
SUMMARY

Add feature to edit instance groups.

@nixocio nixocio self-assigned this Jul 30, 2020
nixocio added a commit to nixocio/awx that referenced this issue Aug 10, 2020
Add feature to edit instance group.

See: ansible#7767
nixocio added a commit to nixocio/awx that referenced this issue Aug 10, 2020
Add feature to edit instance group.

See: ansible#7767
@unlikelyzero unlikelyzero added state:needs_test type:feature prioritized on a feature board labels Aug 10, 2020
nixocio added a commit to nixocio/awx that referenced this issue Aug 11, 2020
Add feature to edit instance group.

See: ansible#7767
@dsesami dsesami self-assigned this Aug 19, 2020
@dsesami
Copy link
Contributor

dsesami commented Aug 20, 2020

This feature was merged, stubs are written. 💯

@dsesami dsesami closed this as completed Aug 20, 2020
honnamkuan added a commit to honnamkuan/awx that referenced this issue Aug 21, 2020
* Correctly parse sumologic url paths
 - Sumologic includes a token with a '==' at the end of it's host path.
   This adds rsyslog conf parsing tests and does not escape equals
   signs.

* allow org admins to remove labels

* Fix misc. linter errors due to the flake8-3.8.1 release
 - [Ref] https://flake8.pycqa.org/en/latest/release-notes/

* properly write rsyslog configuration as 0640

see: https://github.com/ansible/tower/issues/4383

* Bump foreman collection to 0.8.1

* New release includes:
  'add host_filters and want_ansible_ssh_host like script used to have'

* foreman: use group_prefix for all groups

* awx's "compatibility layer" for the foreman plugin had the
  group_prefix hard-coded to 'foreman_'

* delete and re-add host when ip address changes

* The websocket backplane interconnect is done via ip address for
Kubernetes and OpenShift. On init run_wsbroadcast reads all Instances
from the DB and makes a decision to use the ip address or the hostname
based, with preference given to the ip address if defined. For
Kubernetes and OpenShift the nodes can load the Instance before the
ip_address is set. This would cause the connection to be tried by
hostname rather than ip address. This changeset ensures that an ip
address set after an Instance record is created will be detected and
used.

* track stats by hostname not remote host/ip

* broadcast websockets have stats tracked (i.e. connection status,
number of messages total, messages per minute, etc). Previous to this
change, stats were tracked by ip address, if it was defined on the
instance, XOR hostname. This changeset tracks stats by hostname.

* don't block on log aggregator socket.send() calls

see: https://github.com/ansible/tower/issues/4391

* Send content-type with mattermost notifications, fixes ansible#7264

* Make all_parents_must_converge settable when creating node

When targeting, ../workflow_job_templates/id#/workflow_nodes/ endpoint,
user could not set all_parents_must_converge to true.

3.7.1 backport for awx issue ansible#7063

* disable reports option for foreman

* Allow use of fallback instance_ids

* update VMWARE_INSTANCE_ID_VAR

* Favor instanceUuid
* .. but fall back to instanceuuid if necessary

* Add queue / instance group registration to heartbeat for k8s installs

There is some history here.

ansible#7190 <- This PR was an attempt at fixing a
bug notting ran into where some jobs on k8s installs would get stuck in Waiting
forever.

The PR mentioned above introduced a bug where there are no instance groups on a
fresh k8s-based install. This is because this process currently happens in the
launch scripts, before the database is up.

With this patch, queue / instance group registration happens in the heartbeat,
right after auto-registering the instance.

* wrap --instance-id-var in quotes

* revert EC2_INSTANCE_ID_VAR

* UI translation strings for release_3.7.1 branch

* fix a regression in how job host summaries are generated

this change fixes a bug introduced in the optimization at ansible#7352

1. Create inventory with multiple hosts
2. Run a playbook with a limit to match only one host
3. Run job, verify that it only acts on the one host
4. Go to inventory host list and see that all the hosts have last_job updated to point to the job that only acted on one host.

* [DO NOT PORT to AWX] Pin dev requirements (ansible#4413)

* add backwards support for ssl_verify in foreman

* plugin changed option name from
  ssl_verify to validate_cert

* UI translation strings for release_3.7.1 branch for es and nl

* Added the ability, to set the broadcast_websocket_secret variable.
This is nessesary if you would like to rerun the playbook.

Signed-off-by: JoelKle <34544090+JoelKle@users.noreply.github.com>

* Fixed a bug, where the redis.conf first would be stored with mod 0600
and in the next task changed to 0666.
This has broke the ability to rerun the playbook.

Signed-off-by: JoelKle <34544090+JoelKle@users.noreply.github.com>

* Reintroduce label filtering

Labels are visible if you have a role on the org they are in, or
on a job template they're attached to.

* use jinja2.sandbox for credential type injectors

* Don't follow redirects in credential plugins

* Reduce error detail in webhook notification

* Reduce error detail in credential lookups

* prevent unsafe jinja from being saved in the first place for cred types

see: https://github.com/ansible/tower-security/issues/21

* add tests for clarified label permissions

* Include instance_id in host edit request

* fixed broken UI links

* remove the usage of create_temporary_fifo from credential plugins

this resolves an issue that causes an endless hang on with Cyberark AIM
lookups when a certificate *and* key are specified

the underlying issue here is that we can't rely on the underyling Python
ssl implementation to *only* read from the fifo that stores the pem data
*only once*; in reality, we need to just use *actual* tempfiles for
stability purposes

see: ansible#6986
see: urllib3/urllib3#1880

* Upgrade community.vmware for better error surfacing

* Change Dockerfile to copy custom venv

* update the named URL code to properly return 404 vs 403

* Force worker processes to have a different signal handler from the parent

Situations have come up where the 5+ minute kill signal for
run_task_manager is emitted to the worker process running it, but
since the worker improperly inherited the AWXConsumerBase().stop()
handler a deadlock ultimately was triggered on the database
connection.

* properly report 30x errors on credential plugin tests

* pin pytest-forked to fix broken unit tests

* properly obfuscate connection errors for credential lookup failure

* Cache downloaded roles & collections

Populate the cache the first time the job is run for a revision
that needs them, and for future runs for that revision just
copy it into the private directory.

Delete the cache on project deletion.

Invalidate the cache on a new project revision

Also download roles/collections during the sync job

Since we're writing into a per-revision cache, we can do this easily now.

Don't try and install content if there aren't any requirements expecting it

Adjust pathing to the proper location.

Force install if doing a manual sync.

Requirements may be unversioned.

Remove the cache when delete-on-update is set

Integrate content caching with existing task logic

Revert the --force flags

use the update id as metric for role caching

Shift the movement of cache to job folder from rsync task to python

Only install roles and collections if needed

Deal with roles and collections for jobs without sync
Skip local copy if roles or collections turned off

update docs for content caching

Design pivot - use empty cache dir to indicate lack of content

Do not cache content if we did not install content

Test changes to allay concerns about reliability of local_path

Do not blow away cache for SCM inventory updates

Remove project update vars no longer used

Remove job pre-creation of content folders

code style edit, always use cache_id as property in tasks

Fix log message

* Avoid using long name of option not in 2.8

* Use quotations when marking strings for translation

* Add settings framework

* Hide license route based on install and add useConfig hook

* ARM image build support

* upgrade `chromedriver` for ARM support
* upgrade `pynacl` to fix `libsodium` build issue on ARM
* remove unnecessary i686-specific `libstdc++.so.6` package
* install `kubectl` and `tini` from upstream binaries for ARM support
* use upstream `postgres` and `alpine` docker images for `postgresql` helm chart

Fixes ansible#7051

* Fix garbage being printed when exporting as YAML - related ansible#7795

This resolves issue ansible#7795, by passing the `encoding` keyword argument
only when the code is run on a Python 2 interpreter.

related ansible#7795.

* Adds delete functionality to user tokens list

* Removes Inventory Script screens, routes, stubs etc.

* remove vNNN from example migration files

* Create marginally more realistic event data with firehose

* Fix rbac on Add button on User Access/Team Roles lists

* mark PRIMARY_GALAXY_USERNAME and PRIMARY_GALAXY_PASSWORD as deprecated

* Handle form submission errors that may be deeply nested in the return object

* Updated import/export names for consistency

* Adding RuntimeError which is returned from a connection error in awx/main/dispatch/control.py

* Fix isolated dev env

* begin a 14.0.0 changelog

* Bump version to 14.0.0

* Make 'inputs' idempotent in credentials module, add test to check this works

* Add execution environment metadata to AWX collection

* Remove showExpandCollapse prop from the DataListToolbar calls

Remove showExpandCollapse prop from the DataListToolbar calls. This is
not an expected prop to be passed to this component.

Inside DataListToolbar.

```
  const showExpandCollapse = onCompact && onExpand;
```

In order to use this feature, `onCompact` and `onExpand` props should
be passed.

...

* Add advanced search to UI

* Updates to support advanced search changes:
- make set type and lookup prefixes/suffixes on searchColumns explicitly defined
- send possible search keys from options requests on (most) lists

* fix duplicate variable and key usng array index issues

* Add AdvancedSearch propTypes and defaultProps

* Move Search to hooks and excise PF Dropdown in favor of Select

* fix merge conflicts and failing test

* fix AddRersourceRole sort column

* add selectors for cypress tests

* add back in searchable keys props to user token list

* make sortColumnKey error message more clear

* update searchablekeys prop names for project lookup

* make name default searchColumn for ProjectJobTemplatesList.  also add helpful error message to tell you this is the issue

* update rest of lookups to use correct searchableKeys props

* delete inadverdently added back InventoryScriptLookup file

* fix busted flake8 CI

* Fix early return in assign related method

This change fixes an erroneus early return in a private method that was
preventing more than one type of related object from being correctly
assigned to the parent object, and therefore imported.

Also, a minor spelling mistake was corrected.

* Export Workflow Job Template Node Labels

This change adds related Labels to the Workflow Job Template document that is
exported by the AWX CLI.

Previously, exporting and then importing Workflow Job Templates would
not retain their related Labels.

* Update websockets.md

Add documentation for websocket backplane secret key exchange logic.

* Update websockets.md

spelling

* Add feature to add instance group

Add feature to add instance group.

See: ansible#7744

* Refactor organization look to use useRequest hook

* Add smart inventory add form and host filter lookup

* Add smart inventory edit form

* Decode host filter chip values and fix boolean search filter chip bug

* Upgrade gitpython to pick up bug fix

* Revert updater changes to Ansible requirements

* Allow YAML as a CLI import format

This changset allows the import of YAML formatted resources. The CLI
user can indicate which format to use with the `-f, --format` option.
The CLI help text has been amended to reflect the new feature.

The AWX CLI `export` subcommand offers the option of formatting the output
as YAML or JSON, so it makes sense that the `import` subcommand reflects
this.

A simple test is also provided. In order to ease the task of testing
commands that import resources by reading the stdin, the CLI has been
extended to allow specifying an alternative file descriptor for stdin,
similarly to stdout and stderr.

* update to a newer python-ldap to address a bug

see: ansible#7868

* minor cleanup up CLI import -f yaml support

* Change regex to match what is in source

* Add feature to edit instance group

Add feature to edit instance group.

See: ansible#7767

* start notification template list

* flushing out notification template detail

* flush out template detail

* more template details; add template delete button

* add notification status indicator

* send test notifications

* add notification list tests

* add ObjectDetails for HTTP Headers display

* changelog updates for recent additions

* workaround import/dependency bug in tests

* Add smart inventory host list view

* Remove undefined prop from SelectedList call

Remove undefined prop from `SelectedList` call.

* kebabify additional controls when advanced search is displayed

* change name of hook to be useKebabifiedMenu

* add onShowAdvancedSearch callback test

* remove unnecessary selectors from kebabification test

* Add changelog preparing for awx.awx 14.1.0 bug fix

* Update websockets.md

Add more details about backplane websocket functionality.

* Update websockets.md

* Add custom host toggle tooltip for smart inventory hosts

* update existing relatedSearchKey requests to new convention and fix UJT searchKeys

* Adds User Token Details page

* Utilizes UserDateDetail, Capitalizes Scope value, fixes spelling errors

* Support workflow prompting on launch

* Run prettier

* Pin pytest-xdist

* make event stdout encoding more resilient to UTF-16 surrogate pairs

see: https://en.wikipedia.org/wiki/Universal_Character_Set_characters#Surrogates

* Use organization api to create users

This ensures that the user will be related to the chosen organization
when it is created.

* Embolden user organization name

* add a deprecation warning for mercurial project syncs

see: ansible#7932

* adds fix to allow look up to fetch data

* clean up old authtoken support

just use Bearer tokens - those are the only type of tokens we support

* fix a bug that prevents the explicit removal of instances from groups

* Update awx/ui_next/src/components/Lookup/CredentialLookup.jsx

Co-authored-by: Jake McDermott <yo@jakemcdermott.me>

* Adds workflow detail tab to workflow results

* Adding import/export awx kit features

Changed library structure

Origional TowerModule becomes TowerLegacyModule

TowerModule from tower_api becomes TowerAPIModule

A real base TowerModule is created in tower_module.py

A new TowerAWXKitModule is created in tower_awxkit

TowerAWXKitModule and TowerAPIModule are child classes of TowerModule

* Adding integration tests and example in import

* Fix python3 Zuul error with awxkit

* Fixing truthy linting issues

* Removed default: '' and updated [] to '' per specification

* Another linting issue

* Expanding examples

* Fixing linting issues

* Fixing ansible pep8 issues

* Fixing validate-module errors

* Fixing exit_module -> exit_json

* Fix linter whitespace error

* Trying to gobble up logs incase there are errors

* Fixing oauth token login and making module respect token over username/password

* Fixing sanity error

* Updating to remove auth_type since its not longer required

* Trying to make AWXKIT tests not run on python2

* Use a patternfly CSS variable instead of red

Use a patternfly CSS variable instead of red.

See: https://pf4.patternfly.org/documentation/overview/global-css-variables

* changelog for arm64 builds

* more changelog updates

* Add list of jobs for instance groups

Add list of jobs for instance groups.

See: ansible#7930

* Add type column to users list

Add type column to users list. Also, update `UserListItem` to be a
functional component.

See: ansible#5684

* update newly useRequested lists to get advanced searchableKeys

* add searchable keys support for AssociateModal and SelectResourceStep lists

* Adds support for toggling approval notifications on orgs and wfjts

* Add label to show isolated group

Add label to show isolated group.

See: https://tower-mockups.testing.ansible.com/patternfly/instance-groups/instance-groups/

* Only disable single notification row when toggling, not all rows

Co-authored-by: Ryan Petrello <rpetrell@redhat.com>
Co-authored-by: Christian Adams <chadams@redhat.com>
Co-authored-by: beeankha <beeankha@gmail.com>
Co-authored-by: Christian Adams <rooftopcellist@gmail.com>
Co-authored-by: Jim Ladd <jladd@redhat.com>
Co-authored-by: chris meyers <chris.meyers.fsu@gmail.com>
Co-authored-by: Chris Meyers <chrismeyersfsu@users.noreply.github.com>
Co-authored-by: Florian Apolloner <apollo13@users.noreply.github.com>
Co-authored-by: Seth Foster <fosterbseth@gmail.com>
Co-authored-by: Jake McDermott <yo@jakemcdermott.me>
Co-authored-by: AlanCoding <arominge@redhat.com>
Co-authored-by: Shane McDonald <me@shanemcd.com>
Co-authored-by: ansible-translation-bot <ansible-translation-bot@gmail.com>
Co-authored-by: JoelKle <34544090+JoelKle@users.noreply.github.com>
Co-authored-by: Bill Nottingham <notting@splat.cc>
Co-authored-by: Graham Mainwaring <graham@mhn.org>
Co-authored-by: Gabe Muniz <gmuniz@redhat.com>
Co-authored-by: Stefan Jakobs <sjakobs@anexia-it.com>
Co-authored-by: Jeff Bradberry <jeff.bradberry@gmail.com>
Co-authored-by: Marliana Lara <mlara@redhat.com>
Co-authored-by: Andrew Gaffney <andrew@agaffney.org>
Co-authored-by: Rigel Di Scala <rdiscala@redhat.com>
Co-authored-by: softwarefactory-project-zuul[bot] <33884098+softwarefactory-project-zuul[bot]@users.noreply.github.com>
Co-authored-by: Alex Corey <alex.swansboro@gmail.com>
Co-authored-by: mabashian <mabashia@redhat.com>
Co-authored-by: John Westcott IV <john.westcott.iv@redhat.com>
Co-authored-by: beeankha <bstohrer@redhat.com>
Co-authored-by: nixocio <nixocio@gmail.com>
Co-authored-by: John Mitchell <jmitchel@Johns-MacBook-Pro-46.local>
Co-authored-by: John Mitchell <jmitchel@ovpn-114-250.rdu2.redhat.com>
Co-authored-by: Keith Grant <keithjgrant@redhat.com>
Co-authored-by: John Mitchell <jmitchel@ovpn-113-13.rdu2.redhat.com>
Co-authored-by: Alex Corey <acorey@redhat.com>
Co-authored-by: John Mitchell <jmitchel@ovpn-117-206.rdu2.redhat.com>
chrismeyersfsu pushed a commit to chrismeyersfsu/awx that referenced this issue Aug 27, 2020
Add feature to edit instance group.

See: ansible#7767
mabashian pushed a commit to mabashian/awx that referenced this issue Aug 31, 2020
Add feature to edit instance group.

See: ansible#7767
elyezer pushed a commit to ryanpetrello/awx that referenced this issue Sep 1, 2020
Add feature to edit instance group.

See: ansible#7767
AlanCoding pushed a commit to AlanCoding/awx that referenced this issue Sep 10, 2020
Add feature to edit instance group.

See: ansible#7767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature prioritized on a feature board
Projects
None yet
Development

No branches or pull requests

3 participants