Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language selector toolbar (#15334) #15335

Open
wants to merge 11 commits into
base: devel
Choose a base branch
from
Open

Add language selector toolbar (#15334) #15335

wants to merge 11 commits into from

Conversation

irozet12
Copy link
Contributor

@irozet12 irozet12 commented Jul 5, 2024 •
edited
Loading

SUMMARY

Language selection toolbar is added. User can select a language, and reset language to browser default

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • UI
AWX VERSION
awx: 23.7.1.dev84+gde7db88e57.d20240506
ADDITIONAL INFORMATION
Screenshot 2024-07-11 at 18 19 10 Screenshot 2024-07-11 at 18 19 42 Screenshot 2024-07-11 at 18 25 15

@irozet12 irozet12 force-pushed the devel branch 5 times, most recently from c947ce1 to 960591d Compare July 9, 2024 10:38
@irozet12
Add language selector (ansible#15334)
630cfc2 
Signed-off-by: Irina Rozet <irozet12@gmail.com>
@fosterseth
Copy link
Member

fosterseth commented Jul 10, 2024 •
edited
Loading

addresses #15334

can you provide some screenshots of the parts you changed? that is always helpful for reviewers

also, know that the UI in the awx repo will be deprecated. The new UI is here https://github.com/ansible/ansible-ui

@tvo318 tvo318 mentioned this pull request Jul 10, 2024
Open
@irozet12
Copy link
Contributor Author

irozet12 commented Jul 11, 2024 •
edited
Loading

addresses #15334

can you provide some screenshots of the parts you changed? that is always helpful for reviewers

also, know that the UI in the awx repo will be deprecated. The new UI is here https://github.com/ansible/ansible-ui

Thanks for the info. Should I create a PR to ansible-ui? Screenshots are attached

@djyasin
Copy link
Member

djyasin commented Jul 24, 2024

Hi @irozet12! Yes please, if you could please create this pr in the ansible-ui repo? Thank you so much for your time!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 29, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community component:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irozet12 @fosterseth @djyasin