ignore ansible-galaxy-importer in some cases #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore `ansible-galaxy-importer` for: - community.aws - community.okd See: #934
pabelanger
reviewed
May 20, 2021
Comment on lines
+121
to
+122
| - ansible-galaxy-importer: | ||
| voting: false |
There was a problem hiding this comment.
lets remove non-voting from gate, since results are not used for merging
There was a problem hiding this comment.
I'm not sure I understand. ansible-galaxy-importer job also runs during the gating.
There was a problem hiding this comment.
non-voting jobs in gate, are a waste of resources. So, rather making a job non-voting, removing it is better. And nice on nodepool.
There was a problem hiding this comment.
The job is pulled by publish-to-galaxy and I don't want to change project-config just for this temporary fix. I don't see any easy way to disable a job?
This was referenced May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore
ansible-galaxy-importerfor:See: #934