Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong collections path in galaxy-importer job #934

Open
jillr opened this issue May 19, 2021 · 2 comments
Open

Wrong collections path in galaxy-importer job #934

jillr opened this issue May 19, 2021 · 2 comments

Comments

@jillr
Copy link
Collaborator

jillr commented May 19, 2021

After ansible-network/releases#17 stopped bringing in the entire Ansible package it became apparent that the incorrect collections path is being used in this job. Collections which use doc fragments from other collections have been failing CI for all jobs since (ie; community.aws used amazon.aws fragments, and community.okd uses fragments from kubernetes.core).

https://bfcb0036379da16f975f-4282179313616d046bba66d871c7a9ef.ssl.cf5.rackcdn.com/579/16b009a77e4f66d679b0308972f29c92577bf4d3/check/ansible-galaxy-importer/bf50899/job-output.html#l779

In irc we determined this has to do with the collections path
https://gist.github.com/jillr/f2a01a25cc902a1a89194a2dccecf749

@goneri
Copy link
Collaborator

goneri commented May 20, 2021

It's a bug in galaxy-importer. I just opened the issue: https://issues.redhat.com/browse/AAH-650

IMO, the best way to address the problem for now is to embed the fragments in all the collections.

goneri added a commit to goneri/community.okd that referenced this issue May 20, 2021
Import the documentation fragments of kubernetes.core stable-1.2.

See: ansible/ansible-zuul-jobs#934
See: https://issues.redhat.com/browse/AAH-650
@goneri
Copy link
Collaborator

goneri commented May 20, 2021

Another option is to ignore the error like Galaxy does. We already run the sanity tests and they check the documentation consistency.

goneri added a commit to goneri/releases that referenced this issue May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants