Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.0] Backport test fixes #871

Merged
merged 5 commits into from
Oct 15, 2021
Merged

[release-2.0] Backport test fixes #871

merged 5 commits into from
Oct 15, 2021

Conversation

samdoran
Copy link
Contributor

Shrews and others added 5 commits October 14, 2021 18:08
@Shrews @samdoran
Fix test consistency in integration/test_main.py (ansible#838)
e9c27bd
@ansible-zuul @samdoran
Update linter configuration (ansible#772)
19c68cd 
remove section for autopep8 since we don't use it
Change flake8 settings to exclude excludes since the default list of excluded files is good
@ansible-zuul @samdoran
Use mocker fixture (ansible#831)
b7d35b9 
Using the mocker fixture rather than unittest.Mock directly has a number of benefits. The tests read easier since context managers within tests are unnecessary and patches are automatically scoped to the test where the fixture is used.

Also overhaul the tests in test___main__.py to test the code as intended.
@Shrews @samdoran
Add custom linter job (ansible#859)
e2a2e90
@samdoran
Fix unit tests to run consistently in CI and locally (ansible#815)
1cfb060 
Use pytest-mock and tmp_path fixtures
Mock test environment variables to prevent inconsistent test results
Reformat test fixtures so they are easier to read
@samdoran samdoran requested a review from a team as a code owner October 14, 2021 22:14
@samdoran samdoran mentioned this pull request Oct 14, 2021
Merged
@samdoran samdoran added the gate label Oct 15, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 5a8bbb3 into ansible:release_2.0 Oct 15, 2021
@samdoran samdoran deleted the backport/release_2.0/test-fixes branch October 15, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanemcd shanemcd shanemcd approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samdoran @shanemcd @Shrews