Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release_2.0] Accept a dictionary for playbook (#855) #868

Merged

Conversation

samdoran
Copy link
Contributor

Backport of #855 for Ansible Runner 2.0.

@samdoran samdoran requested a review from a team as a code owner October 13, 2021 19:50
@samdoran samdoran added the backport Backport pull request label Oct 13, 2021
@samdoran
Copy link
Contributor Author

Looks like we are missing the test requirements update that installs pytest-mock. I'll have to find that and backport it.

@samdoran
Copy link
Contributor Author

samdoran commented Oct 14, 2021

Depends on #869 #871.

@samdoran samdoran force-pushed the backport-3d6886d-release_2.0 branch 2 times, most recently from e36b254 to 518b149 Compare October 19, 2021 15:05
The validation function isplaybook() expects a playbook to be a list of dictionaries, not a bare dictionary or a string. Update the docs to reflect this requirement and cast a bare dictionary to a list before passing to isplaybook().

(cherry picked from commit 3d6886d)
@samdoran samdoran force-pushed the backport-3d6886d-release_2.0 branch from 518b149 to f7cde3f Compare October 19, 2021 18:38
@Shrews Shrews added the gate label Oct 19, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 4d52f54 into ansible:release_2.0 Oct 19, 2021
@samdoran samdoran deleted the backport-3d6886d-release_2.0 branch October 19, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants