-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to set entrypoint for working_container. #232
Make it possible to set entrypoint for working_container. #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looking good!
Would you be interested in adding the parameter to documentation and writing a test case? If not, I can do that myself.
Absolutely! I will put same time on documentation and testing later this week. |
Added some content and a simple test! But I must say that I don't really know every place where I should add entries for testing. |
/packit build |
Thanks, looking good! This is fine for me. I'm gonna play with it a bit more tomorrow. |
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
and actually use it when creating the build container Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
/packit build |
Based on your Packit configuration the settings of the packit/ansible-community-ansible-bender-232 Copr project would need to be updated as follows:
Packit was unable to update the settings above as it is missing To fix this you can do one of the following:
Please re-trigger the build, once the issue above is fixed. |
I played with it locally a bit and found two issues which I fixed and pushed a commit to your branch. Can someone verify this works correctly? I looked into entrypoint details and the thing is that buildah doesn't seem to use that value for a working container:
Or maybe I don't understand the manpage. |
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
/packit build |
1 similar comment
/packit build |
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
test failures are unrelated, merging thank you for your contribution! |
Fixes #198