Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to set entrypoint for working_container. #232

Conversation

Smeds
Copy link
Contributor

@Smeds Smeds commented Sep 1, 2020

Fixes #198

Copy link
Collaborator

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking good!

Would you be interested in adding the parameter to documentation and writing a test case? If not, I can do that myself.

@Smeds
Copy link
Contributor Author

Smeds commented Sep 2, 2020

Absolutely! I will put same time on documentation and testing later this week.

@Smeds
Copy link
Contributor Author

Smeds commented Sep 2, 2020

Added some content and a simple test! But I must say that I don't really know every place where I should add entries for testing.

@TomasTomecek
Copy link
Collaborator

/packit build

@TomasTomecek
Copy link
Collaborator

Thanks, looking good! This is fine for me. I'm gonna play with it a bit more tomorrow.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-community-ansible-bender-232
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

and actually use it when creating the build container

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek
Copy link
Collaborator

/packit build

@packit-as-a-service
Copy link

Based on your Packit configuration the settings of the packit/ansible-community-ansible-bender-232 Copr project would need to be updated as follows:

field old value new value
chroots ['fedora-31-x86_64'] ['fedora-31-x86_64', 'fedora-30-x86_64']

Packit was unable to update the settings above as it is missing admin permissions on the packit/ansible-community-ansible-bender-232 Copr project.

To fix this you can do one of the following:

  • Grant Packit admin permissions on the packit/ansible-community-ansible-bender-232 Copr project on the permissions page.
  • Change the above Copr project settings manually on the settings page to match the Packit configuration.
  • Update the Packit configuration to match the Copr project settings.

Please re-trigger the build, once the issue above is fixed.

@TomasTomecek
Copy link
Collaborator

I played with it locally a bit and found two issues which I fixed and pushed a commit to your branch.

Can someone verify this works correctly? I looked into entrypoint details and the thing is that buildah doesn't seem to use that value for a working container:

$ man buildah-config
...
       --entrypoint "command" | '["command", "arg1", ...]'

       Set  the  entry point for containers based on any images which will be built using the specified container. buildah supports two formats for entrypoint.  It can be specified as a
       simple string, or as a array of commands.

       Note: When the entrypoint is specified as a string, container runtimes will ignore the cmd value of the container image.  However if you use the array form, then the cmd will  be
       appended onto the end of the entrypoint cmd and be executed together.

Or maybe I don't understand the manpage.

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek
Copy link
Collaborator

/packit build

1 similar comment
@TomasTomecek
Copy link
Collaborator

/packit build

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-community-ansible-bender-232
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TomasTomecek
Copy link
Collaborator

test failures are unrelated, merging

thank you for your contribution!

@TomasTomecek TomasTomecek added the gate Gate PR in Zuul CI label Sep 16, 2020
@ansible-zuul ansible-zuul bot merged commit eb9a06d into ansible-community:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Gate PR in Zuul CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set entrypoint on working container
2 participants