Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set entrypoint on working container #198

Closed
seidzade opened this issue Nov 21, 2019 · 3 comments · Fixed by #232
Closed

Ability to set entrypoint on working container #198

seidzade opened this issue Nov 21, 2019 · 3 comments · Fixed by #232
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@seidzade
Copy link

seidzade commented Nov 21, 2019

Currently, only target_image context supports the setup of the entrypoint, which is affects only "production" image.

In cases, where base image already has an entrypoint, ansible-bender will stuck during the build, due endless process running by container.

This problem can be solved by adding the ability to setup entrypoint for working container , this entrypoint will override the entrypoint of the base image:

 vars:
    ansible_bender:
      working_container:
        entrypoint: <an_entrypoint>
@Smeds
Copy link
Contributor

Smeds commented Aug 28, 2020

Any one working on this?

Does the tag "good first issue" mean that it's a good issue to start with if someone wants to contribute?

@coreyoconnor
Copy link

Does the tag "good first issue" mean that it's a good issue to start with if someone wants to contribute?

Yes. This is a good issue to start with :)

@Smeds
Copy link
Contributor

Smeds commented Sep 1, 2020

I made a pull request (#232 ) that will add the option of setting entrypoint for working_container. This at least solves my problem with getting stuck during the build phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants