Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vcenter_vm_hardware_disk description #548

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Fixes #469
Mention the new disks type in the module description, since mentioned elsewhere

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vcenter_vm_hardware_disk

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.03%. Comparing base (81953ff) to head (d7a10de).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   37.04%   37.03%   -0.01%     
==========================================
  Files         145      145              
  Lines       11388    11391       +3     
  Branches     2258     2259       +1     
==========================================
  Hits         4219     4219              
- Misses       7169     7172       +3     
Flag Coverage Δ
sanity 37.03% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/ed85c4c1a1384d4db2e1a2d090a6c3a9

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 12m 49s
✔️ build-ansible-collection SUCCESS in 7m 12s
✔️ ansible-galaxy-importer SUCCESS in 5m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d1b04da into ansible-collections:main Nov 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcenter_vm_hardware_disk: documentation does not mention Type is always Thin Provision
2 participants