Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

[1d] Remove tests/sanity/requirements.txt from collections #43

Closed
mattclay opened this issue Apr 9, 2020 · 4 comments
Closed

[1d] Remove tests/sanity/requirements.txt from collections #43

mattclay opened this issue Apr 9, 2020 · 4 comments
Assignees
@Andersson007

Comments

@mattclay
Copy link

mattclay commented Apr 9, 2020 •
edited by gundalow
Loading

Some collections have a tests/sanity/requirements.txt file copied from the ansible/ansible repo.

This file is not used by ansible-test and should be removed to avoid confusion. I've seen it in two collections, but others which copied these may also have it:

  • community.general
  • community.zabbix

Call to action

  • Please review your collections for this file and remove it if present. In the PR please reference this issue, so we can track where the fix has been applied.
@felixfontein
Copy link
Contributor

That file also exists in community.crypto and community.network. I guess it was created by the migration script?

This was referenced Apr 10, 2020
Merged
Merged
Merged
@gundalow gundalow mentioned this issue Apr 10, 2020
Closed
This was referenced May 4, 2020
Merged
Merged
@gundalow gundalow changed the title Remove tests/sanity/requirements.txt from collections [1d] Remove tests/sanity/requirements.txt from collections May 6, 2020
@gundalow gundalow removed their assignment May 6, 2020
openstack-mirroring pushed a commit to openstack/ansible-collections-openstack that referenced this issue May 25, 2020
@sshnaidm
Remove unnecessary requirements file
f0da22d 
for reference:
ansible-collections/overview#43
Change-Id: I0136b4d173cb7e1d45a2b4535d8772c68f8d5783
goneri added a commit to goneri/vmware.vmware_rest that referenced this issue Aug 17, 2020
@goneri
ansible-test: drop tests/sanity/requirements.txt
61f5f8d 
`ansible-test` does not read the file.

See: ansible-collections/overview#43
@goneri goneri mentioned this issue Aug 17, 2020
Merged
This was referenced Mar 1, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 1, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Merged
@Andersson007
Copy link
Contributor

@mattclay @gundalow done, the issue can be closed

@gundalow
Copy link
Contributor

gundalow commented Mar 8, 2021

Great work, thanks @Andersson007 this simplifies the repos and reduces confusion.

@gundalow gundalow closed this as completed Mar 8, 2021
@Andersson007
Copy link
Contributor

@gundalow thanks you and everybody who helped to cope with it:)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Andersson007 Andersson007

Labels
None yet
Projects
Community Plan v2
Status: No status
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gregdek @mattclay @gundalow @felixfontein @Andersson007