-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tests/sanity/requirements.txt #177
Merged
ansible-zuul
merged 6 commits into
ansible-collections:main
from
Andersson007:remove_sanity_requirements_txt
Mar 3, 2021
Merged
Remove tests/sanity/requirements.txt #177
ansible-zuul
merged 6 commits into
ansible-collections:main
from
Andersson007:remove_sanity_requirements_txt
Mar 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recheck |
Andersson007
force-pushed
the
remove_sanity_requirements_txt
branch
from
March 2, 2021 13:15
6f4f2a6
to
549f810
Compare
felixfontein
reviewed
Mar 3, 2021
felixfontein
approved these changes
Mar 3, 2021
recheck |
recheck |
gundalow
reviewed
Mar 3, 2021
@@ -2,7 +2,7 @@ | |||
authors: | |||
- Ansible Network Community (ansible-network) | |||
dependencies: | |||
"ansible.netcommon": "2.0.0" | |||
"ansible.netcommon": ">=2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cidrblock @ganeshrn Do we want >=2.0.0, or 2.*?
@felixfontein @gundalow thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ansible-collections/overview#43