Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing whitespace for exos_config with defaults: True #516

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

EdificomSA
Copy link
Contributor

@EdificomSA EdificomSA commented Jan 30, 2023

SUMMARY

Fixes #513

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

exos_config

ADDITIONAL INFORMATION

@EdificomSA
Copy link
Contributor Author

@Andersson007, hi !

cc @LindsayHill @ujwalkomarla @hlrichardson @rdvencioneck @JayalakshmiV @JayalakshmiV you are mentioned as maintainers of exos_ related stuff, so could you please take a look?

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@Andersson007 Andersson007 merged commit 18340ef into ansible-collections:main Feb 15, 2023
@Andersson007 Andersson007 added the backport-5 Automatically create a backport for the stable-5 branch label Feb 15, 2023
@patchback
Copy link

patchback bot commented Feb 15, 2023

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/18340ef55e566ac49921ae139d2383350fea5a06/pr-516

Backported as #525

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 15, 2023
* Missing whitespace for exos_config with defaults: True

Solves #513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 18340ef)
@Andersson007
Copy link
Contributor

@EdificomSA thanks for the contribution!
Feel free also to add yourself as the module's maintainer to .github/BOTMETA.yml (if you're not already there) for the file or group of files.
The bot doesn't work at the moment but in future you'll be notified if someone reports, say, a bug:)

Also could you please backport the changes to stable-4 ? Our bot cannot do it because the file had another path in that version.

Thanks!

Andersson007 pushed a commit that referenced this pull request Feb 15, 2023
* Missing whitespace for exos_config with defaults: True

Solves #513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 18340ef)

Co-authored-by: EdificomSA <118285649+EdificomSA@users.noreply.github.com>
@EdificomSA EdificomSA deleted the patch-1 branch February 17, 2023 13:27
Andersson007 pushed a commit to Andersson007/community.network that referenced this pull request Oct 24, 2023
…ctions#516)

* Missing whitespace for exos_config with defaults: True

Solves ansible-collections#513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 18340ef)
Andersson007 added a commit that referenced this pull request Oct 24, 2023
* Missing whitespace for exos_config with defaults: True

Solves #513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 18340ef)

Co-authored-by: EdificomSA <118285649+EdificomSA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5 Automatically create a backport for the stable-5 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing whitespace for exos_config with defaults: True
3 participants