Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing whitespace for exos_config with defaults: True #513

Closed
EdificomSA opened this issue Jan 11, 2023 · 1 comment · Fixed by #516
Closed

Missing whitespace for exos_config with defaults: True #513

EdificomSA opened this issue Jan 11, 2023 · 1 comment · Fixed by #516
Labels
help_wanted waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@EdificomSA
Copy link
Contributor

EdificomSA commented Jan 11, 2023

SUMMARY

It seems there is a missing whitespace in the command show configurationdetail while using exos_config module with defaults: True

ISSUE TYPE
  • Bug Report
COMPONENT NAME

exos_config.py

ANSIBLE VERSION
ansible [core 2.14.1]
  config file = /home/xxx/gitlab/automation/ansible.cfg
  configured module search path = ['/home/xxx/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/xxx/.cache/pypoetry/virtualenvs/automation-nRq0ZfWj-py3.10/lib/python3.10/site-packages/ansible
  ansible collection location = /home/xxx/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/xxx/.cache/pypoetry/virtualenvs/automation-nRq0ZfWj-py3.10/bin/ansible
  python version = 3.10.9 (main, Dec  7 2022, 01:12:00) [GCC 9.4.0] (/home/xxx/.cache/pypoetry/virtualenvs/automation-nRq0ZfWj-py3.10/bin/python)
  jinja version = 3.0.3
  libyaml = True
COLLECTION VERSION
# /home/xxx/.ansible/collections/ansible_collections
Collection        Version
----------------- -------
community.network 5.0.0  

# /home/xxx/.cache/pypoetry/virtualenvs/automation-nRq0ZfWj-py3.10/lib/python3.10/site-packages/ansible_collections
Collection        Version
----------------- -------
community.network 5.0.0
CONFIGURATION

OS / ENVIRONMENT

Ubuntu 22.04 WSL

STEPS TO REPRODUCE
  - name: EXOS config
    exos_config:
      defaults: True
      lines: "{{ lookup('ansible.builtin.template', './templates/exos_vlan.j2', wantlist=True) }}"
      save_when: modified
      backup: True
EXPECTED RESULTS

show configuration detail

ACTUAL RESULTS

show configurationdetail

`fatal: [switch]: FAILED! => {"changed": false, "msg": "show configurationdetail\r\n\r\u0007                                            ^\r\n%% Invalid input detected at '^' marker.\r\r\n`

flags = ['detail'] if module.params['defaults'] else []

@Andersson007 Andersson007 added waiting_on_contributor Needs help. Feel free to engage to get things unblocked help_wanted labels Jan 12, 2023
@Andersson007
Copy link
Contributor

@EdificomSA hello, thanks for reporting the issue!
The collections needs contributors.
Would you like to fix this yourself and submit a pull request?
You can do it by using:

  • the Quick-start dev guide
  • if this requires changing a line of code, you can also edit the file directly in GH web UI and after that it'll suggest creating a PR

What do you think?
Let me know if you have any questions

EdificomSA added a commit to EdificomSA/community.network that referenced this issue Jan 30, 2023
Andersson007 added a commit that referenced this issue Feb 15, 2023
* Missing whitespace for exos_config with defaults: True

Solves #513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
patchback bot pushed a commit that referenced this issue Feb 15, 2023
* Missing whitespace for exos_config with defaults: True

Solves #513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 18340ef)
Andersson007 pushed a commit that referenced this issue Feb 15, 2023
* Missing whitespace for exos_config with defaults: True

Solves #513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 18340ef)

Co-authored-by: EdificomSA <118285649+EdificomSA@users.noreply.github.com>
Andersson007 pushed a commit to Andersson007/community.network that referenced this issue Oct 24, 2023
…ctions#516)

* Missing whitespace for exos_config with defaults: True

Solves ansible-collections#513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 18340ef)
Andersson007 added a commit that referenced this issue Oct 24, 2023
* Missing whitespace for exos_config with defaults: True

Solves #513

* changelog

* changelog yaml error

* Update changelogs/fragments/516-whitespace-exos-config-defaults.yaml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

---------

Co-authored-by: Yannis Ansermoz <yannis.ansermoz@edificom.ch>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit 18340ef)

Co-authored-by: EdificomSA <118285649+EdificomSA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help_wanted waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants