redhat_subscription: use CLI when using environments #6319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptoscano
force-pushed
the
redhat_subscription-no-dbus-with-environments
branch
from
3468afa to
19a71e5
Compare
ansibullbot
added
bug
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
It turns out that the 'environments' that the D-Bus Register*() APIs accept are the IDs of the environments, and not the user-facing names of the environments (which is what the module has been accepting so far). Since there is no easy way to do the mapping manually, for now use again the subscription-manager CLI for registering when environments are specified.
ptoscano
force-pushed
the
redhat_subscription-no-dbus-with-environments
branch
from
19a71e5 to
a74bd2f
Compare
ansibullbot
removed
ci_verified
This was referenced Apr 11, 2023
felixfontein
added
check-before-release
|
@ptoscano looks good to me. Do you want to wait for reviews, or should I merge? |
Should be OK, thanks! |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6332 🤖 @patchback |
felixfontein
removed
the
check-before-release
|
@ptoscano thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
It turns out that the 'environments' that the D-Bus Register*() APIs accept are the IDs of the environments, and not the user-facing names of the environments (which is what the module has been accepting so far). Since there is no easy way to do the mapping manually, for now use again the subscription-manager CLI for registering when environments are specified. (cherry picked from commit 83994c0)
felixfontein
pushed a commit
that referenced
this pull request
Apr 13, 2023
…hen using environments (#6332) redhat_subscription: use CLI when using environments (#6319) It turns out that the 'environments' that the D-Bus Register*() APIs accept are the IDs of the environments, and not the user-facing names of the environments (which is what the module has been accepting so far). Since there is no easy way to do the mapping manually, for now use again the subscription-manager CLI for registering when environments are specified. (cherry picked from commit 83994c0) Co-authored-by: Pino Toscano <ptoscano@redhat.com>
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It turns out that the 'environments' that the D-Bus Register*() APIs accept are the IDs of the environments, and not the user-facing names of the environments (which is what the module has been accepting so far).
Since there is no easy way to do the mapping manually, for now use again the subscription-manager CLI for registering when environments are specified.
ISSUE TYPE
COMPONENT NAME
redhat_subscription