Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(meta): stop pinning community.general collection #91

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

ptoscano
Copy link
Collaborator

@ptoscano ptoscano commented Apr 12, 2023

The issues in the redhat_subscription module shipped in the community.general collection were fixed in version 6.6.0, so it should not have regressions now.

Hence, stop pinning the community.general collection.

This reverts commit 26c0f43.

@ptoscano
Copy link
Collaborator Author

Keeping it as draft until all the prerequisites are satisfied.

@ptoscano
Copy link
Collaborator Author

@richm @spetrosi please note the requirements, so for now this cannot go in. I'll keep it updated when it's possible to even test this.

@richm
Copy link
Contributor

richm commented Apr 24, 2023

6.6.0 was released - https://galaxy.ansible.com/community/general

@ptoscano ptoscano force-pushed the unpin-community.general branch from b332b66 to eae34e7 Compare April 25, 2023 04:38
@ptoscano
Copy link
Collaborator Author

[citest]

@ptoscano ptoscano marked this pull request as ready for review April 25, 2023 04:43
@ptoscano ptoscano marked this pull request as draft April 25, 2023 05:24
@ptoscano
Copy link
Collaborator Author

Hmm there's something wrong with some scenarios in Fedora -- this will need more investigations.

@ptoscano
Copy link
Collaborator Author

OK, I see what's the problem: with newer dbus (1.12.24+ and 1.14.4+), the socket created as /run/dbus-* for a new D-Bus server (created to have a secure bus for the registration) is no more an abstract socket, but a real Unix socket file. The SELinux policy in Fedora does not allow rhsmcertd_t to create sockets, and thus it fails with EACCES as result of the SELinux denial. (There is also another issue in sub-man itself, as the failure when starting a new D-Bus server is not properly handled.)

I'll need to get this added in the Fedora SELinux policy first.

@richm
Copy link
Contributor

richm commented Apr 25, 2023

OK, I see what's the problem: with newer dbus (1.12.24+ and 1.14.4+), the socket created as /run/dbus-* for a new D-Bus server (created to have a secure bus for the registration) is no more an abstract socket, but a real Unix socket file. The SELinux policy in Fedora does not allow rhsmcertd_t to create sockets, and thus it fails with EACCES as result of the SELinux denial. (There is also another issue in sub-man itself, as the failure when starting a new D-Bus server is not properly handled.)

I'll need to get this added in the Fedora SELinux policy first.

As an alternative - can we use the selinux system role to ensure this policy exists in the rhc role?

@ptoscano
Copy link
Collaborator Author

can we use the selinux system role to ensure this policy exists in the rhc role?

I don't think so. The fix for this would likely be allowing unix sockets operations to the rhsmcertd module, and I don't see this capability in the selinux role.

@richm
Copy link
Contributor

richm commented Apr 27, 2023

can we use the selinux system role to ensure this policy exists in the rhc role?

I don't think so. The fix for this would likely be allowing unix sockets operations to the rhsmcertd module, and I don't see this capability in the selinux role.

@bachradsusi is it possible to do this with the selinux role?

@bachradsusi
Copy link
Member

can we use the selinux system role to ensure this policy exists in the rhc role?

I don't think so. The fix for this would likely be allowing unix sockets operations to the rhsmcertd module, and I don't see this capability in the selinux role.

@bachradsusi is it possible to do this with the selinux role?

Using selinux role it would be possible to ship and install a local module which would allow this. But it would be just a temporary hack. It really needs to be enabled in rhsm selinux policy. cc @zpytela

@ptoscano
Copy link
Collaborator Author

But it would be just a temporary hack. It really needs to be enabled in rhsm selinux policy. cc @zpytela

Yes, I already contacted Zdeněk about this issue some days ago ;-)

The issues in the redhat_subscription module shipped in the
community.general collection were fixed in version 6.6.0, so it should
not have regressions now.

Hence, stop pinning the community.general collection.

This reverts commit 26c0f43.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
@ptoscano ptoscano force-pushed the unpin-community.general branch from eae34e7 to 6074c61 Compare June 5, 2023 15:54
@ptoscano ptoscano changed the title Stop pinning community.general collection chore(meta): stop pinning community.general collection Jun 5, 2023
@ptoscano
Copy link
Collaborator Author

ptoscano commented Jun 5, 2023

The issues related to Fedora will be handled separately; this should be good for a EL-only POV.

@ptoscano ptoscano marked this pull request as ready for review June 5, 2023 15:55
@ptoscano
Copy link
Collaborator Author

ptoscano commented Jun 5, 2023

[citest]

@richm richm merged commit c181954 into linux-system-roles:main Jun 5, 2023
@ptoscano ptoscano deleted the unpin-community.general branch June 6, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants