Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6114/6cf67448 backport][stable-6] memset*.py: Fixed URLError handling #6157

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 8, 2023

This is a backport of PR #6114 as merged into main (6cf6744).

SUMMARY

Hi,

the memset modules are currently missing URLError handling.

Current behavior
grafik

Expected behavior
grafik

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • memset.py
  • memset_zone.py
  • memset_zone_record.py
  • memset_zone_domain.py
  • memset_server_info.py
  • memset_memstore_info.py
  • memset_dns_reload.py
ADDITIONAL INFORMATION

Steps to reproduce:

Run the following Playbook and turn off your internet connection:

---
- name: Example playbook for localhost
  hosts: localhost
  gather_facts: no

  tasks:

    - name:
      community.general.memset_server_info:
        api_key: "12345678abcdefghi"
        name: "test"
      ignore_errors: true

    - name:
      community.general.memset_dns_reload:
        api_key: "12345678abcdefghi"
      ignore_errors: true

    - name:
      community.general.memset_memstore_info:
        api_key: "12345678abcdefghi"
        name: "test"
      ignore_errors: true

    - name:
      community.general.memset_zone_domain:
        api_key: "12345678abcdefghi"
        domain: "test"
        zone: "test"
      ignore_errors: true

    - name:
      community.general.memset_zone_record:
        api_key: "12345678abcdefghi"
        type: A
        zone: "test"
        address: "ip"
      ignore_errors: true

    - name:
      community.general.memset_zone:
        api_key: "12345678abcdefghi"
        state: present
        name: "test"
      ignore_errors: true

* memset.py: Added URLError exception and stderr to Response() object

* memset_*.py: Check response.status_code and response.stderr

* Added changelog fragment

* memset.py: Fixed pep8

* Renamed changelog fragment with .yml file extension

(cherry picked from commit 6cf6744)
@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug cloud module module module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) labels Mar 8, 2023
@felixfontein felixfontein merged commit 36eff2f into stable-6 Mar 8, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-6/6cf674485ff85c46ce7fd1464ac4f71a22e93aa0/pr-6114 branch March 8, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug cloud module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants