-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memset*.py: Fixed URLError handling #6114
memset*.py: Fixed URLError handling #6114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking this looks fine, however I no longer work for Memset and I haven't worked on these modules in years.
I'll merge if nobody objects in, say, a week. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #6156 🤖 @patchback |
* memset.py: Added URLError exception and stderr to Response() object * memset_*.py: Check response.status_code and response.stderr * Added changelog fragment * memset.py: Fixed pep8 * Renamed changelog fragment with .yml file extension (cherry picked from commit 6cf6744)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6157 🤖 @patchback |
* memset.py: Added URLError exception and stderr to Response() object * memset_*.py: Check response.status_code and response.stderr * Added changelog fragment * memset.py: Fixed pep8 * Renamed changelog fragment with .yml file extension (cherry picked from commit 6cf6744)
@danopt thanks for your contribution! |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
…dling (#6156) memset*.py: Fixed URLError handling (#6114) * memset.py: Added URLError exception and stderr to Response() object * memset_*.py: Check response.status_code and response.stderr * Added changelog fragment * memset.py: Fixed pep8 * Renamed changelog fragment with .yml file extension (cherry picked from commit 6cf6744) Co-authored-by: Daniel Patrick <dani.p1991@gmail.com>
…dling (#6157) memset*.py: Fixed URLError handling (#6114) * memset.py: Added URLError exception and stderr to Response() object * memset_*.py: Check response.status_code and response.stderr * Added changelog fragment * memset.py: Fixed pep8 * Renamed changelog fragment with .yml file extension (cherry picked from commit 6cf6744) Co-authored-by: Daniel Patrick <dani.p1991@gmail.com>
SUMMARY
Hi,
the memset modules are currently missing URLError handling.
Current behavior
Expected behavior
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Steps to reproduce:
Run the following Playbook and turn off your internet connection: