Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6138/3d67f518 backport][stable-6] Fix Yarn global not working without explicit executable path #6141

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 4, 2023

This is a backport of PR #6138 as merged into main (3d67f51).

SUMMARY

Fixes #6132.

PR #5829 added a call to yarn global dir to select the correct global directory, but this ran before the default value of the executable param was set from the PATH.

This PR moves that logic out of the Yarn class initializer so the executable is identified just before it's needed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yarn

ADDITIONAL INFORMATION

See #6132 for repro.

(Also cc @JohnDaly as this probably affects y'all)

* Fix Yarn global not working without explicit executable path

* changelog fragment

* fix formatting and add test

* oops

(cherry picked from commit 3d67f51)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) tests tests labels Mar 4, 2023
@felixfontein felixfontein merged commit 8efbd81 into stable-6 Mar 4, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-6/3d67f51824c65035083e995206738166bb3a0de0/pr-6138 branch March 4, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants