Fix Yarn global not working without explicit executable path #6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
sargunv
force-pushed
the
sv/fix-yarn-regression
branch
from
0b90b06 to
e1ea7ca
Compare
ansibullbot
added
the
needs_revision
sargunv
force-pushed
the
sv/fix-yarn-regression
branch
from
e1ea7ca to
a7ae59d
Compare
|
Test failure looks like a timeout in an unrelated test; re-running by amending commit timestamp and force pushing |
ansibullbot
removed
the
needs_revision
felixfontein
added
check-before-release
felixfontein
approved these changes
Mar 4, 2023
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6141 🤖 @patchback |
|
@sargunv thanks for fixing this! |
patchback bot
pushed a commit
that referenced
this pull request
Mar 4, 2023
* Fix Yarn global not working without explicit executable path * changelog fragment * fix formatting and add test * oops (cherry picked from commit 3d67f51)
felixfontein
pushed a commit
that referenced
this pull request
Mar 4, 2023
…thout explicit executable path (#6141) Fix Yarn global not working without explicit executable path (#6138) * Fix Yarn global not working without explicit executable path * changelog fragment * fix formatting and add test * oops (cherry picked from commit 3d67f51) Co-authored-by: Sargun Vohra <sargun.vohra@gmail.com>
felixfontein
removed
the
check-before-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #6132.
PR #5829 added a call to
yarn global dirto select the correct global directory, but this ran before the default value of theexecutableparam was set from thePATH.This PR moves that logic out of the
Yarnclass initializer so the executable is identified just before it's needed.ISSUE TYPE
COMPONENT NAME
yarn
ADDITIONAL INFORMATION
See #6132 for repro.
(Also cc @JohnDaly as this probably affects y'all)