Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opkg: fix issue that force=reinstall would not reinstall an existing package #5705

Merged

Conversation

joergho
Copy link
Contributor

@joergho joergho commented Dec 19, 2022

SUMMARY

opkg: fix issue that force=reinstall would not reinstall an existing package

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • opkg
ADDITIONAL INFORMATION

Tested with opkg 0.4.2 on NI Linux Real-Time 8.8

Bug noticed while working on #5688

…package

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>
@ansibullbot

This comment was marked as outdated.

@ansibullbot
Copy link
Collaborator

cc @skinp
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug ci_verified Push fixes to PR branch to re-run CI module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor os packaging plugins plugin (any type) labels Dec 19, 2022
@joergho joergho force-pushed the opkg_fix_force_reinstall branch from 4f22397 to b3facdc Compare December 19, 2022 08:46
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 19, 2022
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small markup adjustment in the chglog frag, other than that LGTM

changelogs/fragments/5705-opkg-fix-force-reinstall.yml Outdated Show resolved Hide resolved
@joergho joergho force-pushed the opkg_fix_force_reinstall branch from b3facdc to 18aa210 Compare December 19, 2022 10:11
@felixfontein felixfontein merged commit 2b39470 into ansible-collections:main Dec 19, 2022
@patchback
Copy link

patchback bot commented Dec 19, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/2b39470a774c28e26780e4e2e4cc9b998471da3c/pr-5705

Backported as #5710

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 19, 2022
…package (#5705)

* opkg: fix issue that force=reinstall would not reinstall an existing package

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

* changelog fragment

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>
(cherry picked from commit 2b39470)
@patchback
Copy link

patchback bot commented Dec 19, 2022

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/2b39470a774c28e26780e4e2e4cc9b998471da3c/pr-5705

Backported as #5711

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@joergho thanks for fixing this!
@russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Dec 19, 2022
…package (#5705)

* opkg: fix issue that force=reinstall would not reinstall an existing package

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

* changelog fragment

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>
(cherry picked from commit 2b39470)
felixfontein pushed a commit that referenced this pull request Dec 19, 2022
…nstall would not reinstall an existing package (#5710)

opkg: fix issue that force=reinstall would not reinstall an existing package (#5705)

* opkg: fix issue that force=reinstall would not reinstall an existing package

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

* changelog fragment

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>
(cherry picked from commit 2b39470)

Co-authored-by: joergho <48011876+joergho@users.noreply.github.com>
felixfontein pushed a commit that referenced this pull request Dec 19, 2022
…nstall would not reinstall an existing package (#5711)

opkg: fix issue that force=reinstall would not reinstall an existing package (#5705)

* opkg: fix issue that force=reinstall would not reinstall an existing package

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

* changelog fragment

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>
(cherry picked from commit 2b39470)

Co-authored-by: joergho <48011876+joergho@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor os packaging plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants