opkg module: allow installing a package in a certain version #5688

joergho · 2022-12-15T12:21:47Z

SUMMARY

This extends the community.general.opkg module. It additionally allows to install a package in a certain version.

Tested with opkg 0.4.2 on NI Linux Real-Time 8.8

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

community.general.opkg module

ADDITIONAL INFORMATION

opkg module: allow NAME=VERSION syntax to install a package in a certain version

example:

- name: Install foo in version 1.2
  community.general.opkg:
    name: foo=1.2
    state: present

ansibullbot · 2022-12-15T12:24:31Z

cc @skinp
click here for bot help

github-actions · 2022-12-15T12:47:30Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

felixfontein

Thanks for your contribution! I've added some first comments.

changelogs/fragments/5688-opkg-module-install-certain-version.yml

plugins/modules/opkg.py

joergho · 2022-12-16T09:55:50Z

@felixfontein
Thanks for your review. I addressed all your review comments.

I also noticed that there was a bug that parameter force=reinstall would not actually reinstall a package if it was already installed. I introduced a fix for this: 5bd3977

felixfontein · 2022-12-17T11:16:40Z

Could you please move the bugfix to a new PR so we can backport it also to stable-5? Thanks.

joergho · 2022-12-19T08:37:59Z

Could you please move the bugfix to a new PR so we can backport it also to stable-5? Thanks.

Sure. See PR #5705

felixfontein

Looks good to me (looking at the code; I cannot test it). Now there is a conflict that needs to be resolved though (please rebase).

example: - name: Install foo in version 1.2 community.general.opkg: name: foo=1.2 state: present Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

joergho · 2022-12-20T07:50:44Z

Looks good to me (looking at the code; I cannot test it). Now there is a conflict that needs to be resolved though (please rebase).

Rebased in 5232803

Also I executed a test with python3.10 and opkg 0.4.2 on NI Linux Real-Time 8.8:

opkg-tests.yml:

- name: "opkg tests"
  gather_facts: no

  tasks:
  - name: "opkg remove (1)"
    community.general.opkg:
        name: "tmux"
        state: "absent"

  - name: "opkg remove (2)"
    community.general.opkg:
        name: "tmux"
        state: "absent"

  - name: "opkg install (1)"
    community.general.opkg:
        name: "tmux"
        state: "present"

  - name: "opkg install (2)"
    community.general.opkg:
        name: "tmux"
        state: "present"

  - name: "install --force-reinstall"
    community.general.opkg:
        name: "tmux"
        state: "present"
        force: "reinstall"

  - name: "opkg remove (3)"
    community.general.opkg:
        name: "tmux"
        state: "absent"

  - name: "opkg install with version"
    community.general.opkg:
        name: "tmux=2.6-r0.18"
        state: "present"

  - name: "opkg install with incorrect version"
    community.general.opkg:
        name: "tmux=2.6"
        state: "present"

$ ansible-playbook opkg-tests.yml

PLAY [opkg tests] **************************************************************************************************************************

TASK [opkg remove (1)] **************************************************************************************************************************
changed: [agent01]

TASK [opkg remove (2)] **************************************************************************************************************************
ok: [agent01]

TASK [opkg install (1)] **************************************************************************************************************************
changed: [agent01]

TASK [opkg install (2)] **************************************************************************************************************************
ok: [agent01]

TASK [install --force-reinstall] **************************************************************************************************************************
changed: [agent01]

TASK [opkg remove (3)] **************************************************************************************************************************
changed: [agent01]

TASK [opkg install with version] **************************************************************************************************************************
changed: [agent01]

TASK [opkg install with incorrect version] **************************************************************************************************************************
fatal: [agent01]: FAILED! => {"changed": false, "msg": "failed to install tmux=2.6: No packages installed or removed.\n"}

PLAY RECAP **************************************************************************************************************************
agent01 : ok=7 changed=5 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0

felixfontein · 2022-12-20T11:50:43Z

Thanks for testing it! :) I'll keep this open a few more days and will then merge it if nobody objects until then.

felixfontein · 2022-12-22T18:31:09Z

Merging so that #5718 can rebase and advance.

patchback · 2022-12-22T18:31:36Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b3485b8fcab59e47d7460c3473329a9d516c3ea0/pr-5688

Backported as #5724

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* opkg: allow installing a package in a certain version example: - name: Install foo in version 1.2 community.general.opkg: name: foo=1.2 state: present Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com> * opkg: use list for passing arguments to run_command Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com> Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com> (cherry picked from commit b3485b8)

felixfontein · 2022-12-22T18:31:47Z

@joergho thanks for contributing this!

…a package in a certain version (#5724) opkg module: allow installing a package in a certain version (#5688) * opkg: allow installing a package in a certain version example: - name: Install foo in version 1.2 community.general.opkg: name: foo=1.2 state: present Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com> * opkg: use list for passing arguments to run_command Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com> Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com> (cherry picked from commit b3485b8) Co-authored-by: joergho <48011876+joergho@users.noreply.github.com>

ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor os packaging plugins plugin (any type) labels Dec 15, 2022

joergho force-pushed the opkg_name_version_syntax branch from f8d7fab to 3b06754 Compare December 15, 2022 12:28

joergho changed the title ~~opkg module: allow NAME=VERSION syntax~~ opkg module: allow installing a package in a certain version Dec 15, 2022

joergho force-pushed the opkg_name_version_syntax branch from 3b06754 to 787796c Compare December 15, 2022 12:31

This comment was marked as outdated.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 15, 2022

joergho force-pushed the opkg_name_version_syntax branch from 308a181 to 1eeeaca Compare December 15, 2022 13:24

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 15, 2022

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Dec 15, 2022

felixfontein reviewed Dec 15, 2022

View reviewed changes

joergho force-pushed the opkg_name_version_syntax branch from 1eeeaca to 5bd3977 Compare December 16, 2022 09:49

joergho force-pushed the opkg_name_version_syntax branch from 7beae34 to ccdd57b Compare December 19, 2022 08:26

joergho mentioned this pull request Dec 19, 2022

opkg: fix issue that force=reinstall would not reinstall an existing package #5705

Merged

This was referenced Dec 19, 2022

[PR #5705/2b39470a backport][stable-5] opkg: fix issue that force=reinstall would not reinstall an existing package #5710

Merged

[PR #5705/2b39470a backport][stable-6] opkg: fix issue that force=reinstall would not reinstall an existing package #5711

Merged

felixfontein reviewed Dec 19, 2022

View reviewed changes

ansibullbot removed the new_contributor Help guide this first time contributor label Dec 19, 2022

ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 19, 2022

joergho added 2 commits December 20, 2022 08:06

opkg: allow installing a package in a certain version

1a677fa

example: - name: Install foo in version 1.2 community.general.opkg: name: foo=1.2 state: present Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

opkg: use list for passing arguments to run_command

5232803

Signed-off-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

joergho force-pushed the opkg_name_version_syntax branch from ccdd57b to 5232803 Compare December 20, 2022 07:06

felixfontein approved these changes Dec 20, 2022

View reviewed changes

ansibullbot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 20, 2022

felixfontein mentioned this pull request Dec 22, 2022

opkg: refactor module to use StateModuleHelper and CmdRunner #5718

Merged

felixfontein merged commit b3485b8 into ansible-collections:main Dec 22, 2022

patchback bot mentioned this pull request Dec 22, 2022

[PR #5688/b3485b8f backport][stable-6] opkg module: allow installing a package in a certain version #5724

Merged

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 22, 2022

felixfontein mentioned this pull request Aug 5, 2024

opkg - _package_in_desired_state does not handle properly opkg list_installed output #8706

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

opkg module: allow installing a package in a certain version #5688

opkg module: allow installing a package in a certain version #5688

joergho commented Dec 15, 2022

ansibullbot commented Dec 15, 2022

github-actions bot commented Dec 15, 2022 •

edited

Loading

This comment was marked as outdated.

felixfontein left a comment

joergho commented Dec 16, 2022

felixfontein commented Dec 17, 2022

joergho commented Dec 19, 2022

felixfontein left a comment

joergho commented Dec 20, 2022

felixfontein commented Dec 20, 2022

felixfontein commented Dec 22, 2022

patchback bot commented Dec 22, 2022 •

edited

Loading

felixfontein commented Dec 22, 2022

opkg module: allow installing a package in a certain version #5688

opkg module: allow installing a package in a certain version #5688

Conversation

joergho commented Dec 15, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Dec 15, 2022

github-actions bot commented Dec 15, 2022 • edited Loading

Docs Build 📝

This comment was marked as outdated.

felixfontein left a comment

Choose a reason for hiding this comment

joergho commented Dec 16, 2022

felixfontein commented Dec 17, 2022

joergho commented Dec 19, 2022

felixfontein left a comment

Choose a reason for hiding this comment

joergho commented Dec 20, 2022

felixfontein commented Dec 20, 2022

felixfontein commented Dec 22, 2022

patchback bot commented Dec 22, 2022 • edited Loading

Backport to stable-6: 💚 backport PR created

felixfontein commented Dec 22, 2022

github-actions bot commented Dec 15, 2022 •

edited

Loading

patchback bot commented Dec 22, 2022 •

edited

Loading