Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #5100/83317419 backport][stable-5] pipx: add required_if fo upgrade and reinstall #5102

Merged
merged 1 commit into from
Aug 9, 2022
Merged

[PR #5100/83317419 backport][stable-5] pipx: add required_if fo upgrade and reinstall #5102

merged 1 commit into from
Aug 9, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 9, 2022

This is a backport of PR #5100 as merged into main (8331741).

SUMMARY

Add required_if clause for states upgrade and reinstall, requiring parameter name. That mimics the behaviour of the underlying pipx, effectively making the module fail faster in that situation.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

pipx

@russoz @patchback
pipx: add required_if fo upgrade and reinstall (#5100)
e7241cc 
* pipx: add required_if for upgrade and reinstall

* add changelog fragment

(cherry picked from commit 8331741)
@patchback patchback bot mentioned this pull request Aug 9, 2022
Merged
@ansibullbot
Copy link
Collaborator

cc @russoz
click here for bot help

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request integration tests/integration language module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor packaging plugins plugin (any type) tests tests and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 9, 2022
@felixfontein felixfontein merged commit e962da8 into stable-5 Aug 9, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/83317419d7249051e75b1a5c84879677df79f056/pr-5100 branch August 9, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request integration tests/integration language module module new_contributor Help guide this first time contributor packaging plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @russoz