Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipx: add required_if fo upgrade and reinstall #5100

Merged
merged 2 commits into from
Aug 9, 2022
Merged

pipx: add required_if fo upgrade and reinstall #5100

merged 2 commits into from
Aug 9, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Aug 8, 2022

SUMMARY

Add required_if clause for states upgrade and reinstall, requiring parameter name. That mimics the behaviour of the underlying pipx, effectively making the module fail faster in that situation.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

pipx

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request integration tests/integration language module module packaging plugins plugin (any type) tests tests labels Aug 8, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Aug 9, 2022
@felixfontein felixfontein merged commit 8331741 into ansible-collections:main Aug 9, 2022
@patchback
Copy link

patchback bot commented Aug 9, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/83317419d7249051e75b1a5c84879677df79f056/pr-5100

Backported as #5102

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 9, 2022
@russoz @patchback
pipx: add required_if fo upgrade and reinstall (#5100)
e7241cc 
* pipx: add required_if for upgrade and reinstall

* add changelog fragment

(cherry picked from commit 8331741)
@patchback patchback bot mentioned this pull request Aug 9, 2022
Merged
@felixfontein
Copy link
Collaborator

@russoz thanks!

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 9, 2022
felixfontein pushed a commit that referenced this pull request Aug 9, 2022
@patchback @russoz
pipx: add required_if fo upgrade and reinstall (#5100) (#5102)
e962da8 
* pipx: add required_if for upgrade and reinstall

* add changelog fragment

(cherry picked from commit 8331741)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the pipx-req-if branch August 9, 2022 09:43
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@russoz
pipx: add required_if fo upgrade and reinstall (ansible-collections#5100
518471a 
)

* pipx: add required_if for upgrade and reinstall

* add changelog fragment
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@russoz
pipx: add required_if fo upgrade and reinstall (ansible-collections#5100
377ff30 
)

* pipx: add required_if for upgrade and reinstall

* add changelog fragment
@trux-bot trux-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@lumiere-bot lumiere-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ergho-bot ergho-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@angelnu-bot angelnu-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ghost ghost mentioned this pull request Nov 7, 2022
Merged
1 task
@feisar-bot feisar-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@iudicael-bot iudicael-bot bot mentioned this pull request Nov 7, 2022
Closed
1 task
@negative-7-bot negative-7-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request integration tests/integration language module module packaging plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @felixfontein @ansibullbot