[PR #4903/265c052c backport][stable-4] Fix command variable usage in CmdRunner #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-4/265c052c27f5d3d1b2fc80a771172f32140d0140/pr-4903
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4903 as merged into main (265c052).
SUMMARY
It exists a bug in CmdRunner where the wrong "command" variable is being used in order to get the binary path.
Before executing, it is ensured that the command is a list.
self.command = _ensure_list(command)However, further in the code,
command[0]is used instead ofself.command[0].self.command[0] = module.get_bin_path(command[0], opt_dirs=path_prefix, required=True)Because of this, if command is a string (p.e. xfconf-query),
get_bin_pathwill look for "x" instead of "xfconf-query".ISSUE TYPE
COMPONENT NAME
plugins/module_utils/cmd_runner.py
ADDITIONAL INFORMATION
Right now, this is affecting the following components: