Fix command variable usage in CmdRunner #4903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
There was a problem hiding this comment.
Thanks for your contribution! Could you please add a changelog fragment? Thanks.
felixfontein
added
check-before-release
|
@felixfontein done! |
felixfontein
approved these changes
Jun 29, 2022
|
CC @russoz |
russoz
approved these changes
Jun 29, 2022
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4905 🤖 @patchback |
|
@alvarontwrk thanks for fixing this! |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #4906 🤖 @patchback |
felixfontein
removed
the
check-before-release
felixfontein
pushed a commit
that referenced
this pull request
Jun 30, 2022
felixfontein
pushed a commit
that referenced
this pull request
Jun 30, 2022
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
* Fix command variable usage * Add changelog fragment for cmd-runner bugfix (ansible-collections#4903)
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
* Fix command variable usage * Add changelog fragment for cmd-runner bugfix (ansible-collections#4903)
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It exists a bug in CmdRunner where the wrong "command" variable is being used in order to get the binary path.
Before executing, it is ensured that the command is a list.
self.command = _ensure_list(command)However, further in the code,
command[0]is used instead ofself.command[0].self.command[0] = module.get_bin_path(command[0], opt_dirs=path_prefix, required=True)Because of this, if command is a string (p.e. xfconf-query),
get_bin_pathwill look for "x" instead of "xfconf-query".ISSUE TYPE
COMPONENT NAME
plugins/module_utils/cmd_runner.py
ADDITIONAL INFORMATION
Right now, this is affecting the following components: