Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #4791/739ca737 backport][stable-5] cmd_runner: add __call__ method to invoke context #4844

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 15, 2022

This is a backport of PR #4791 as merged into main (739ca73).

SUMMARY

Method context() renamed to __call__(), but retaining an alias from the old name to the new one, for compatibility.
That change will allow a more concise idiom when running the commands.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/cmd_runner.py

* cmd_runner: add __call__ method to invoke context

* change xfconf to use the callable form

* add changelog fragment

* Update changelogs/fragments/4791-cmd-runner-callable.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 739ca73)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request module module module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests unit tests/unit labels Jun 15, 2022
@felixfontein felixfontein merged commit eafcdfb into stable-5 Jun 15, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/739ca737f1bce3d6e8dd2caa1cd6749faa4e2106/pr-4791 branch June 15, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants