cmd_runner: add __call__ method to invoke context #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
felixfontein
reviewed
Jun 6, 2022
felixfontein
added
check-before-release
|
@felixfontein do you mean that uses |
|
And I have unit tests for both usages. |
|
I mean changing some of the existing code that uses |
That will prove that Python works as expected. :-P Anyways, done. |
felixfontein
reviewed
Jun 9, 2022
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Jun 10, 2022
felixfontein
removed
the
check-before-release
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #4844 🤖 @patchback |
|
@russoz thanks for this improvement! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
* cmd_runner: add __call__ method to invoke context * change xfconf to use the callable form * add changelog fragment * Update changelogs/fragments/4791-cmd-runner-callable.yaml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 739ca73)
felixfontein
pushed a commit
that referenced
this pull request
Jun 15, 2022
* cmd_runner: add __call__ method to invoke context * change xfconf to use the callable form * add changelog fragment * Update changelogs/fragments/4791-cmd-runner-callable.yaml Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 739ca73) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
1 task
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Method
context()renamed to__call__(), but retaining an alias from the old name to the new one, for compatibility.That change will allow a more concise idiom when running the commands.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/cmd_runner.py