Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certifi dropped Python 2 support #4702

Merged
merged 2 commits into from
May 19, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Add constraint so that systems with outdated pip2s don't try to install a bad version.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

CI

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added small_patch Hopefully easy to review tests tests unit tests/unit labels May 19, 2022
@ansibullbot ansibullbot added integration tests/integration needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed small_patch Hopefully easy to review labels May 19, 2022
@felixfontein felixfontein merged commit 8421af1 into ansible-collections:main May 19, 2022
@felixfontein felixfontein deleted the ci2 branch May 19, 2022 12:48
@patchback
Copy link

patchback bot commented May 19, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/8421af1ea39b650dbd27ea2ddf9b97f865a56fcc/pr-4702

Backported as #4703

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 19, 2022
* certifi dropped Python 2 support.

* Apparently the consul tests didn't use the constraints.

(cherry picked from commit 8421af1)
@patchback
Copy link

patchback bot commented May 19, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/8421af1ea39b650dbd27ea2ddf9b97f865a56fcc/pr-4702

Backported as #4704

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 19, 2022
* certifi dropped Python 2 support.

* Apparently the consul tests didn't use the constraints.

(cherry picked from commit 8421af1)
@patchback
Copy link

patchback bot commented May 19, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/8421af1ea39b650dbd27ea2ddf9b97f865a56fcc/pr-4702

Backported as #4705

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 19, 2022
* certifi dropped Python 2 support.

* Apparently the consul tests didn't use the constraints.

(cherry picked from commit 8421af1)
felixfontein added a commit that referenced this pull request May 19, 2022
* certifi dropped Python 2 support.

* Apparently the consul tests didn't use the constraints.

(cherry picked from commit 8421af1)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request May 19, 2022
* certifi dropped Python 2 support.

* Apparently the consul tests didn't use the constraints.

(cherry picked from commit 8421af1)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request May 19, 2022
* certifi dropped Python 2 support.

* Apparently the consul tests didn't use the constraints.

(cherry picked from commit 8421af1)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests/integration needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants