Skip to content

Commit

Permalink
certifi dropped Python 2 support (#4702)
Browse files Browse the repository at this point in the history
* certifi dropped Python 2 support.

* Apparently the consul tests didn't use the constraints.
  • Loading branch information
felixfontein authored May 19, 2022
1 parent db1010a commit 8421af1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/integration/targets/consul/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ dependencies:
- setup_pkg_mgr
- setup_openssl
- setup_remote_tmp_dir
- setup_remote_constraints
2 changes: 2 additions & 0 deletions tests/integration/targets/consul/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@
- name: Install requests<2.20 (CentOS/RHEL 6)
pip:
name: requests<2.20
extra_args: "-c {{ remote_constraints }}"
register: result
until: result is success
when: ansible_distribution_file_variety|default() == 'RedHat' and ansible_distribution_major_version is version('6', '<=')
- name: Install python-consul
pip:
name: python-consul
extra_args: "-c {{ remote_constraints }}"
register: result
until: result is success
- name: Generate privatekey
Expand Down
1 change: 1 addition & 0 deletions tests/utils/constraints.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
certifi < 2022.5.18 ; python_version < '3.5' # certifi 2022.5.18 requires Python 3.5 or later
coverage >= 4.2, < 5.0.0, != 4.3.2 ; python_version <= '3.7' # features in 4.2+ required, avoid known bug in 4.3.2 on python 2.6, coverage 5.0+ incompatible
coverage >= 4.5.4, < 5.0.0 ; python_version > '3.7' # coverage had a bug in < 4.5.4 that would cause unit tests to hang in Python 3.8, coverage 5.0+ incompatible
cryptography < 2.2 ; python_version < '2.7' # cryptography 2.2 drops support for python 2.6
Expand Down

0 comments on commit 8421af1

Please sign in to comment.