virtualmachine: Add support for Disk Encryption Set parameter #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/lm-sig/azure into feature/vm-disk-encryption-set-v2
|
There are currently (2023-11-01) no merge conflicts and no outstanding review issues. Please review as soon possible. Thanks. |
* Add required description to document * new change for required_if * Add missing ']'
Fred-sun
reviewed
Nov 3, 2023
Fred-sun
added
medium_priority
* Delete unnecessary required sets * Modify azure_rm_virtualnetworkgaway.py * restore azure_rm_mysqlfirewallrule.py change
* Bump version to v1.19.0 * The storage_profile is not a required parameter for creation * update doc * update doc * restore azure_rm_galleryimageversion.py changes * update doc --------- Co-authored-by: xuzhang3 <xuzhang3@microsoft.com>
* Add auth_mode to azure_rm_storageblob Add the parameter `auth_mode` to the `azure_rm_storageblob` module, making it possible to create blobs without using access keys. * Fix sanity tests * Add integration tests Test using auth_mode='login' for storage blobs. This has been tested on a machine with MSI. * Remove spaces around equal sign
) * Add encryption to azure_rm_galleryimageversion Add the parameter `encryption` to `target_regions` of the `azure_rm_galleryimageversion` module, making it possible to create encrypted images. Fixes ansible-collections#1290 * Fix documentation * Add disk encryption to gallery image version tests Add the usage of disk encryption to all regions in the tests of the module azure_rm_galleryimageversion. This required a fix, moving the deprecated managed_image to storage_profile.source_image instead.
* Add features to azure_rm_galleryimage Add the parameter `features` to the `azure_rm_galleryimage` module, making it possible to create VMs with Trusted Launch from these images. * Add integration tests Switch gallery image definition to Hyper-V generation V2 and enable TrustedLaunch.
* add ansible-core v2.16 * add v2.16 * ignore for v2.16 * ignore for v2.16 * ignore for v2.16
* migrate to msgraph * migrate to msgraph * migrate to msgraph * migrate to ms graph API * ad group info * app info and group info * migrate to msgraph * spn msgraph * migrate AD to MS graph * Migrate AAD API to MSGraph API for ServicePrincipal, User and Password (ansible-collections#1280) * migrate sp and fix application * migrate azure_rm_adserviceprincipal.py * migrate azure_rm_aduser_info.py * migrate azure_rm_adpassword_info.py * migrate azure_rm_aduser.py * Migrate azure_rm_adpassword.py and fix azure_rm_adpassword_info.py * update azure_rm_adserviceprincipal.py * update azure_rm_adserviceprincipal_info.py * update azure_rm_aduser.py * update azure_rm_aduser_info.py * update azure_rm_adpassword.py * update azure_rm_adpassword_info.py * update azure_rm_aduser.py * update azure_rm_adpassword.py * update azure_rm_adpassword_info.py * update azure_rm_adpassword.py to use add_password and remove_password * update azure_rm_aduser_info.py to add select * update azure_rm_aduser.py to add select * update code * update code * update code * update code * update code * update code --------- Co-authored-by: neil-yechenwei <v-cheye@microsoft.com> * cli auth * auth with CLI * Get the existing user after create (ansible-collections#1286) Co-authored-by: neil-yechenwei <v-cheye@microsoft.com> * Add advanced query filter to get the existing user by list (ansible-collections#1287) Co-authored-by: neil-yechenwei <v-cheye@microsoft.com> * get app by app id * fix lint * fix sanity * fix sanity * fix sanity * fix sanity * deprecate tenant ID * Mark the property for deprecating and renaming property (ansible-collections#1294) * Mark the property for deprecating and renaming property * update code * update code --------- Co-authored-by: neil-yechenwei <v-cheye@microsoft.com> * deprecate tenant ID * msgraph sdk v1.0.0 * deprecate tenant ID * update doc * fix lint * fix lint * remove blank space * fix lint * fix lint * fix lint * remove tenant * extend test timeout * update adapp response --------- Co-authored-by: Neil Ye <yechenwei2007@hotmail.com> Co-authored-by: neil-yechenwei <v-cheye@microsoft.com>
ansible-collections#1316 # Conflicts: # plugins/modules/azure_rm_virtualmachine.py
|
I added a test case and updated to the latest 'dev' branch changes. As of today (2023-11-13) there should be no outstanding issues. Thanks. |
|
It's unfortunate Red Hat / @ephracis didn't see this was being worked on for several months, but thank you for the update. I guess this can be closed. Is there an ETA on the 1.19.0 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
Supersedes #1217
SUMMARY
I had a requirement to have virtual machines with disks (both OS and data) that used encryption. The VM module did not support provisioning or attaching any disk type with encryption enabled.
Fixes #425
ISSUE TYPE
COMPONENT NAME
azure_vm_virtualmachine
ADDITIONAL INFORMATION
A customer may set an Azure policy that requires VMs to have disks with encryption. If you attempt to provision a virtual machine with disks without encryption your request will fail.
This change will support both encrypted or unencrypted disks. Currently it requires you to provide the full Azure resource ID for the data encryption set ID.