Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to encrypt gallery image version #1290

Closed
ephracis opened this issue Oct 16, 2023 · 0 comments · Fixed by #1311
Closed

Ability to encrypt gallery image version #1290

ephracis opened this issue Oct 16, 2023 · 0 comments · Fixed by #1311
Labels
enhancement New feature or request has_pr PR fixes have been made medium_priority Medium priority

Comments

@ephracis
Copy link
Contributor

SUMMARY

Add the ability to encrypt Gallery Image Version with customer provided keys.

This is done by specifying --target-region-encryption in the CLI.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure_rm_galleryimageversion

ADDITIONAL INFORMATION

This is how it is done using the CLI:

az sig image-version create \
   -g MyResourceGroup \
   --gallery-image-version 1.0.0 \
   --location westus\
   --target-regions westus=2=standard_lrs eastus\
   --target-region-encryption WestUSDiskEncryptionSet1,0,WestUSDiskEncryptionSet2 EastUS2DiskEncryptionSet1,0,EastUS2DiskEncryptionSet2 \
   --os-snapshot "/subscriptions/<subscription ID>/resourceGroups/myResourceGroup/providers/Microsoft.Compute/snapshots/myOSSnapshot" \
   --data-snapshot-luns 0 \
   --data-snapshots "/subscriptions/<subscription ID>/resourceGroups/myResourceGroup/providers/Microsoft.Compute/snapshots/myDDSnapshot" \
   --gallery-name MyGallery \
   --gallery-image-definition MyImage

Source: https://learn.microsoft.com/en-us/azure/virtual-machines/image-version-encryption
ephracis added a commit to ephracis/azure that referenced this issue Oct 31, 2023
@ephracis
Add encryption to azure_rm_galleryimageversion
3ddf18e 
Add the parameter `encryption` to `target_regions` of the
`azure_rm_galleryimageversion` module, making it possible to create
encrypted images.

Fixes ansible-collections#1290
ephracis added a commit to ephracis/azure that referenced this issue Oct 31, 2023
@ephracis
Add encryption to azure_rm_galleryimageversion
9793c2d 
Add the parameter `encryption` to `target_regions` of the
`azure_rm_galleryimageversion` module, making it possible to create
encrypted images.

Fixes ansible-collections#1290
@ephracis ephracis mentioned this issue Oct 31, 2023
Merged
@Fred-sun Fred-sun added enhancement New feature or request ready_for_review The PR has been modified and can be reviewed and merged has_pr PR fixes have been made medium_priority Medium priority and removed ready_for_review The PR has been modified and can be reviewed and merged labels Nov 1, 2023
ephracis added a commit to ephracis/azure that referenced this issue Nov 2, 2023
@ephracis
Add encryption to azure_rm_galleryimageversion
9637412 
Add the parameter `encryption` to `target_regions` of the
`azure_rm_galleryimageversion` module, making it possible to create
encrypted images.

Fixes ansible-collections#1290
xuzhang3 pushed a commit that referenced this issue Nov 9, 2023
@ephracis
Add encryption to azure_rm_galleryimageversion (#1311)
ecf0c86 
* Add encryption to azure_rm_galleryimageversion

Add the parameter `encryption` to `target_regions` of the
`azure_rm_galleryimageversion` module, making it possible to create
encrypted images.

Fixes #1290

* Fix documentation

* Add disk encryption to gallery image version tests

Add the usage of disk encryption to all regions in the tests of the
module azure_rm_galleryimageversion.

This required a fix, moving the deprecated managed_image to
storage_profile.source_image instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request has_pr PR fixes have been made medium_priority Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add encryption to azure_rm_galleryimageversion ephracis/azure
2 participants
@ephracis @Fred-sun