Split cloudformation unit test fix off from module_util migrations #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
unit_tests/cloudformation
branch
from
d63a1c6 to
a02f6b2
Compare
jillr
approved these changes
May 13, 2020
|
Thanks @flowerysong for the fix, and @tremble for splitting it out so it can merge faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix unit test failures cause by #38 and made visible by #45
ISSUE TYPE
COMPONENT NAME
cloudformation
ADDITIONAL INFORMATION
Shamelessly split off from #26 (Thanks/Sorry @flowerysong)