Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations to AnsibleAWSModule (and related cleanup) #38

Merged
merged 11 commits into from
May 5, 2020

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 26, 2020

SUMMARY

Migrate a batch of modules to AnsibleAWSModule and perform related cleanup

  • remove ec2_argument_spec use
  • remove HAS_BOTO3 logic
  • cleanup HAS_BOTO logic
  • Use module.client() to get boto3 clients
  • Pull camel_dict_to_snake_dict from its canonical source
  • Use module.fail_json_aws and is_boto3_error_code to simplify error handling
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/cloudformation.py
plugins/modules/ec2.py
plugins/modules/ec2_elb_lb.py
plugins/modules/ec2_eni.py
plugins/modules/ec2_eni_info.py
plugins/modules/ec2_snapshot.py
plugins/modules/ec2_snapshot_info.py
plugins/modules/ec2_vol.py
plugins/modules/ec2_vpc_dhcp_option.py
plugins/modules/ec2_vpc_dhcp_option_info.py
plugins/modules/ec2_vpc_net_info.py
plugins/modules/ec2_vpc_subnet_info.py

ADDITIONAL INFORMATION

@tremble tremble force-pushed the awsmodule/amazon.aws branch from 4157273 to 965648f Compare April 26, 2020 17:53
@tremble tremble force-pushed the awsmodule/amazon.aws branch from 965648f to a12b656 Compare April 26, 2020 18:17
@tremble tremble force-pushed the awsmodule/amazon.aws branch from 6b7f196 to ffe5e87 Compare April 26, 2020 19:24
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tremble!

@jillr jillr merged commit 84e52e6 into ansible-collections:master May 5, 2020
@jillr jillr mentioned this pull request May 6, 2020
@tremble tremble deleted the awsmodule/amazon.aws branch May 28, 2021 07:07
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Added explicit encoding for key_data string.
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Added explicit encoding for key_data string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants