Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code disappears after formatting an already formatted file #114

Closed
lukaszcz opened this issue Jun 19, 2023 · 3 comments · Fixed by #115
Closed

Code disappears after formatting an already formatted file #114

lukaszcz opened this issue Jun 19, 2023 · 3 comments · Fixed by #115
Assignees
Labels
bug Something isn't working high-priority

Comments

@lukaszcz
Copy link
Contributor

The entire file text disappears.

@lukaszcz lukaszcz added bug Something isn't working high-priority labels Jun 19, 2023
@vrom911 vrom911 self-assigned this Jun 19, 2023
@vrom911
Copy link
Contributor

vrom911 commented Jun 19, 2023

This is due to the anoma/juvix#2173 missing from the release.
@paulcadman is currently reapplying it in this PR in Juvix: anoma/juvix#2205

@paulcadman
Copy link
Collaborator

There's a good point from @lukaszcz in anoma/juvix#2205 - will syntax errors make the code disappear when formatting? Even after that PR is merged? Do we need to change something in the format command to help?

@vrom911
Copy link
Contributor

vrom911 commented Jun 19, 2023

The way it currently works, in case of the error, it will not change the content of the file, but will just display the error we got from the command. So with the error case, no changes are required by the vscode extension 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants