Always print source of formatted file unless --check is specified #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the source of a file that was already formatted was not output by the formatter. If the `format: false` pragma is set then the source is echoed verbatim, without highlighting.
|
What happens when there is a syntax error? |
The corresponding parse error will be printed to stderr |
|
I hope the VSCode extension can handle that error and won't make the code disappear. |
Good point! @vrom911 can you help with this? |
|
This is the case. Current problem was with the different expectations of the output with the |
jonaprieto
pushed a commit
to anoma/vscode-juvix
that referenced
this pull request
Jun 19, 2023
Resolves #114 Together with anoma/juvix#2205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was already merged in #2173, but main was subsequently forced pushed as part of the 0.4.0 release and these changes were erased by mistake.
This PR changes the behaviour of the formatter when run on files that are already formatted. Previously the source of a file that was already formatted was not output by the formatter.
After this PR, the formatter always outputs the contents of a formatted file (when used on a single file, and if the --check option is not specified).
If the
format: falsepragma is set then the source is echoed verbatim, without highlighting (because it's not possible to get the highlighting without the formatting).This probably helps implementing the formatter in the vscode extension, see anoma/vscode-juvix#98