Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client missing help messages (backport #4047) #4049

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

Describe your changes

Closes #4022.

Adds a call to arg_required_else_help for TxCustom, TxInitAccount and QueryFindValidator to print the command's help message when no arguments are provided.

Modified QueryFindValidator to carry a single address instead of two and updated the logic of query_find_validator to account for this.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4047 done by [Mergify](https://mergify.com).

@grarco grarco self-requested a review November 19, 2024 16:55
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (8c4f48d) to head (73c5d2a).
Report is 6 commits behind head on maint-0.45.

Additional details and impacted files
@@             Coverage Diff             @@
##           maint-0.45    #4049   +/-   ##
===========================================
  Coverage       74.05%   74.06%           
===========================================
  Files             341      341           
  Lines          106561   106561           
===========================================
+ Hits            78912    78920    +8     
+ Misses          27649    27641    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 19, 2024
@mergify mergify bot merged commit 2840f81 into maint-0.45 Nov 19, 2024
23 of 24 checks passed
@mergify mergify bot deleted the mergify/bp/maint-0.45/pr-4047 branch November 19, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant