-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix client missing help messages #4047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
- Coverage 74.25% 74.25% -0.01%
==========================================
Files 341 341
Lines 107271 107271
==========================================
- Hits 79651 79650 -1
- Misses 27620 27621 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
tzemanovic
approved these changes
Nov 19, 2024
tzemanovic
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Nov 19, 2024
3 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 19, 2024
Fix client missing help messages (backport #4047)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking:SDK
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4022.
Adds a call to
arg_required_else_help
forTxCustom
,TxInitAccount
andQueryFindValidator
to print the command's help message when no arguments are provided.Modified
QueryFindValidator
to carry a single address instead of two and updated the logic ofquery_find_validator
to account for this.Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo