Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client missing help messages #4047

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Fix client missing help messages #4047

merged 5 commits into from
Nov 19, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Nov 19, 2024

Describe your changes

Closes #4022.

Adds a call to arg_required_else_help for TxCustom, TxInitAccount and QueryFindValidator to print the command's help message when no arguments are provided.

Modified QueryFindValidator to carry a single address instead of two and updated the logic of query_find_validator to account for this.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (47fc912) to head (f88fb82).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4047      +/-   ##
==========================================
- Coverage   74.25%   74.25%   -0.01%     
==========================================
  Files         341      341              
  Lines      107271   107271              
==========================================
- Hits        79651    79650       -1     
- Misses      27620    27621       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@grarco grarco marked this pull request as ready for review November 19, 2024 13:56
@grarco grarco requested a review from tzemanovic November 19, 2024 13:56
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 19, 2024
mergify bot added a commit that referenced this pull request Nov 19, 2024
@mergify mergify bot merged commit a0b3a7d into main Nov 19, 2024
25 of 38 checks passed
@mergify mergify bot deleted the grarco/fix-help-msgs branch November 19, 2024 16:44
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
(cherry picked from commit f88fb82)
mergify bot added a commit that referenced this pull request Nov 19, 2024
Fix client missing help messages (backport #4047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:SDK merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing output on find-validator
2 participants