Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor epoch pairs #3050

Closed
wants to merge 1 commit into from
Closed

Refactor epoch pairs #3050

wants to merge 1 commit into from

Conversation

honeygoyal120
Copy link

Describe your changes

The PoS code has lots of instances of an (Epoch, Epoch) being passed around, and it is not always intuitive as to what this epoch pair is exactly. It would be cleaner and enhance readability to instead pass around a struct, perhaps named EpochBounds or similar, that contains explicit start and end epoch fields that can be used for various operations.

Indicate on which release or other PRs this topic is based on

#1732

@brentstone
Copy link
Collaborator

Hi, thanks for your interest in developing. I assume you've seen #1731, which started to address this issue #1732 a while ago on a much older version of the software. Properly addressing this issue will likely require lots of changes to the proof-of-stake code.

Feel free to ask questions if needed, though I may not be able to help guide you very much as we are quite busy working on other higher-priority development. This issue is pretty low-priority, which is why #1731 has become quite stale.

Also, under Describe your changes you can simply write Closes #1732 instead of copying the text from #1732. Then, for the base of the PR, please put a release version or other PR (like 0.32.1 or whatever it is) rather than an issue.

If I see development on this PR become stale in the next week or two, I'll close it.

@honeygoyal120
Copy link
Author

Okay Thanks @brentstone

@brentstone brentstone closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants