Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor epoch pairs #1732

Open
Tracked by #2006
brentstone opened this issue Jul 17, 2023 · 0 comments
Open
Tracked by #2006

Refactor epoch pairs #1732

brentstone opened this issue Jul 17, 2023 · 0 comments
Labels
PoS post-mainnet Don't worry about this yet. refactor / code quality
Milestone
Nice to have and ...

Comments

@brentstone
Copy link
Collaborator

The PoS code has lots of instances of an (Epoch, Epoch) being passed around, and it is not always intuitive as to what this epoch pair is exactly. It would be cleaner and enhance readability to instead pass around a struct, perhaps named EpochBounds or similar, that contains explicit start and end epoch fields that can be used for various operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PoS post-mainnet Don't worry about this yet. refactor / code quality
Projects
None yet
Milestone
Nice to have and non-breaking
Development

Successfully merging a pull request may close this issue.

Refactor epoch pairs anoma/namada
3 participants
@tzemanovic @cwgoes @brentstone