Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PGF balance from total native supply #3002

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Apr 3, 2024

Describe your changes

Closes #2983.

Indicate on which release or other PRs this topic is based on

v0.32.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.44%. Comparing base (61a0759) to head (eb9d7a7).

Files Patch % Lines
crates/sdk/src/queries/vp/token.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
- Coverage   53.44%   53.44%   -0.01%     
==========================================
  Files         310      310              
  Lines      101574   101578       +4     
==========================================
- Hits        54288    54285       -3     
- Misses      47286    47293       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone marked this pull request as ready for review April 4, 2024 14:59
@brentstone brentstone requested a review from tzemanovic April 4, 2024 14:59
brentstone added a commit that referenced this pull request Apr 6, 2024
* brent/remove-pgf-from-total-supply:
  changelog: add #3002
  cleanup balance reading
  update total supply RPC call
  use effective total supply in inflation
  get effective total native supply
tzemanovic added a commit that referenced this pull request Apr 8, 2024
* origin/brent/remove-pgf-from-total-supply:
  changelog: add #3002
  cleanup balance reading
  update total supply RPC call
  use effective total supply in inflation
  get effective total native supply
brentstone added a commit that referenced this pull request Apr 8, 2024
* brent/remove-pgf-from-total-supply:
  changelog: add #3002
  cleanup balance reading
  update total supply RPC call
  use effective total supply in inflation
  get effective total native supply
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/brent/remove-pgf-from-total-supply:
  changelog: add #3002
  cleanup balance reading
  update total supply RPC call
  use effective total supply in inflation
  get effective total native supply

# Conflicts:
#	crates/proof_of_stake/src/rewards.rs
#	crates/shielded_token/src/conversion.rs
@tzemanovic tzemanovic merged commit 5de7646 into main Apr 12, 2024
18 of 19 checks passed
@tzemanovic tzemanovic deleted the brent/remove-pgf-from-total-supply branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtract unspent PGF funds from total supply
3 participants