Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit metadata size #2845

Merged
merged 7 commits into from
Apr 12, 2024
Merged

Limit metadata size #2845

merged 7 commits into from
Apr 12, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Mar 7, 2024

Describe your changes

Closes #2800.

Indicate on which release or other PRs this topic is based on

v0.31.9

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 11.32075% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 53.84%. Comparing base (cc3edde) to head (fa33c45).
Report is 117 commits behind head on main.

Files Patch % Lines
crates/sdk/src/tx.rs 0.00% 59 Missing ⚠️
crates/apps/src/lib/config/genesis/transactions.rs 25.53% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2845      +/-   ##
==========================================
- Coverage   53.88%   53.84%   -0.05%     
==========================================
  Files         308      308              
  Lines      100154   100261     +107     
==========================================
+ Hits        53967    53981      +14     
- Misses      46187    46280      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brentstone added a commit that referenced this pull request Mar 8, 2024
tzemanovic
tzemanovic previously approved these changes Mar 8, 2024
Copy link
Contributor

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also validate genesis metadata
(crates/apps/src/lib/config/genesis/transactions.rs)

sug0
sug0 previously approved these changes Mar 8, 2024
brentstone added a commit that referenced this pull request Mar 8, 2024
brentstone added a commit that referenced this pull request Mar 8, 2024
brentstone added a commit that referenced this pull request Mar 8, 2024
tzemanovic added a commit that referenced this pull request Apr 1, 2024
* origin/brent/limit-metadata-size:
  fix bug for deleting metadata
  genesis metadata validation
  changelog: add #2845
  refactor
  check metadata length in client
  check metadata length in VP
tzemanovic added a commit that referenced this pull request Apr 1, 2024
* brent/limit-metadata-size:
  wasm/vp_user: only read metadata if it's changed
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/brent/limit-metadata-size:
  wasm/vp_user: only read metadata if it's changed
  fix bug for deleting metadata
  genesis metadata validation
  changelog: add #2845
  refactor
  check metadata length in client
  check metadata length in VP

# Conflicts:
#	crates/sdk/src/tx.rs
@tzemanovic tzemanovic merged commit a7a8393 into main Apr 12, 2024
14 of 19 checks passed
@tzemanovic tzemanovic deleted the brent/limit-metadata-size branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No validation of size or format on CLI parameters for the validator metadata
3 participants