fix: add validation on email and discord handle in cli

[phy-chain]

Describe your changes

Indicate on which release or other PRs this topic is based on

This has been reported in : #2800

Checklist before merging to draft

• I have added a changelog
• Git history is in acceptable state
• Add a test for email validation
• Add a test for discord handle validation

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 53.91%. Comparing base (2535c9c) to head (d2948e6).

❗ Current head d2948e6 differs from pull request most recent head 1e33228. Consider uploading reports for the commit 1e33228 to get more accurate results

Files	Patch %	Lines
crates/apps/src/lib/cli.rs	0.00%	66 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
- Coverage   53.95%   53.91%   -0.04%     
==========================================
  Files         308      308              
  Lines      100018   100084      +66     
==========================================
- Hits        53967    53965       -2     
- Misses      46051    46119      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brentstone]

@phy-chain thanks for starting this. It is more correct and appropriate to enforce these constraints in the user VP (vp_user.rs) rather than exclusively in the client, however.

We do a similar thing already in the native Governance VP with the restriction of the size of a governance proposal content. Check out is_valid_content_key insde the Gov VP (crates::namada::src::ledger::governance::mod.rs) for some guidance.

Make sure to include a test as well.

[phy-chain]

@phy-chain thanks for starting this. It is more correct and appropriate to enforce these constraints in the user VP (vp_user.rs) rather than exclusively in the client, however.

We do a similar thing already in the native Governance VP with the restriction of the size of a governance proposal content. Check out is_valid_content_key insde the Gov VP (crates::namada::src::ledger::governance::mod.rs) for some guidance.

Make sure to include a test as well.

Ah yes, I did see that, That was my source of inspiration for the MetadataValidation structure actually. But I didnt get how that worked with VP thing.
Ok for the test, I'll keep that in mind to implement it

[brentstone]

@phy-chain I'm happy to help at some point soon since this is important, but I don't have the bandwidth for probably a couple days.

[phy-chain]

@phy-chain I'm happy to help at some point soon since this is important, but I don't have the bandwidth for probably a couple days.

@brentstone No rush, Im glad to help, even though Im a total newby at Rust (Im a frontend dev first and foremost).
I've pushed a new commit to try and go in the right direction. Let me know if it looks better or if Im heading into troubles :D

I've started a test case but on that, it's a complete mystery how to generate "test data" that's relevant, and test against it. So, i've copied and existing test and added some TODOs as a reflexion basis.

Feel free to ping me when you have time (better to do so on Discord cause I might not see notifications here). It can also be after the SE if you're too busy.

[brentstone]

hey @phy-chain, in some planning today we decided that the priority for this is higher than previously thought, so I went ahead and made a quick PR #2845 to complete this. I'll close this PR for now, but perhaps keep your branch around in case. Thanks for the effort and for identifying #2800!

[phy-chain]

Lol ok, that's a way to go at it 😅 500 chars limit for all. Still better than nothing I guess :D
Feel free to keep that around and ping me if need be.