Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Ethereum Bridge functionality at compile time #2602

Merged
merged 11 commits into from
Apr 12, 2024

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Feb 12, 2024

Describe your changes

Closes #2598
Closes #2027

Indicate on which release or other PRs this topic is based on

v0.31.4

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 added ethereum-bridge pre-mainnet Must happen before mainnet. labels Feb 12, 2024
sug0 added a commit that referenced this pull request Feb 14, 2024
@sug0 sug0 marked this pull request as ready for review February 14, 2024 16:30
sug0 added a commit that referenced this pull request Feb 14, 2024
@tzemanovic
Copy link
Member

it would be good to add the feature to Cargo.tomls and propagate it through the deps

@sug0
Copy link
Contributor Author

sug0 commented Feb 15, 2024

it would be good to add the feature to Cargo.tomls and propagate it through the deps

I left it out of this PR on purpose. Figured we won't be enabling the Bridge any time soon, anyway. I can add it to the manifest files, though.

Copy link
Member

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to still run the unit tests with bridge enabled in the ci. Otherwise they won't be maintained and will rot and potentially be a big headache later.

sug0 added a commit that referenced this pull request Feb 16, 2024
sug0 added a commit that referenced this pull request Feb 16, 2024
sug0 added a commit that referenced this pull request Feb 16, 2024
sug0 added a commit that referenced this pull request Feb 16, 2024
@sug0
Copy link
Contributor Author

sug0 commented Feb 16, 2024

added a CI task to run eth bridge tests

sug0 added a commit that referenced this pull request Feb 16, 2024
sug0 added a commit that referenced this pull request Feb 16, 2024
sug0 added a commit that referenced this pull request Feb 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 51.38%. Comparing base (2535c9c) to head (c9d0a56).
Report is 165 commits behind head on main.

Files Patch % Lines
...apps/src/lib/node/ledger/shell/process_proposal.rs 73.61% 19 Missing ⚠️
crates/apps/src/lib/cli/relayer.rs 0.00% 13 Missing ⚠️
.../ethereum_bridge/src/storage/eth_bridge_queries.rs 70.27% 11 Missing ⚠️
...e/ledger/shell/vote_extensions/bridge_pool_vext.rs 66.66% 10 Missing ⚠️
crates/apps/src/lib/cli/client.rs 0.00% 8 Missing ⚠️
crates/apps/src/lib/node/ledger/shell/mod.rs 61.11% 7 Missing ⚠️
...ib/node/ledger/shell/vote_extensions/eth_events.rs 66.66% 5 Missing ⚠️
...ge/src/protocol/validation/validator_set_update.rs 54.54% 5 Missing ⚠️
...ode/ledger/shell/vote_extensions/val_set_update.rs 66.66% 4 Missing ⚠️
crates/ethereum_bridge/src/storage/parameters.rs 50.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2602      +/-   ##
==========================================
- Coverage   53.95%   51.38%   -2.58%     
==========================================
  Files         308      308              
  Lines      100018    99000    -1018     
==========================================
- Hits        53967    50872    -3095     
- Misses      46051    48128    +2077     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

batconjurer
batconjurer previously approved these changes Feb 19, 2024
tzemanovic
tzemanovic previously approved these changes Feb 22, 2024
@sug0 sug0 marked this pull request as draft February 29, 2024 11:23
@sug0 sug0 dismissed stale reviews from tzemanovic and batconjurer via c9d0a56 February 29, 2024 12:35
@sug0 sug0 marked this pull request as ready for review February 29, 2024 12:35
tzemanovic added a commit that referenced this pull request Apr 3, 2024
* origin/tiago/comptime-eth-bridge:
  Changelog for #2602
  Enable Ethereum bridge testing in CI
  Include Makefile target to test Eth bridge
  Add `namada-eth-bridge` feature to Cargo manifests
  Stop benchmarking Ethereum bridge txs and vps
  Disable Namada Eth bridge CLI cmds
  Disable and/or adjust Bridge pool VP tests
  Disable Bridge pool txs
  Factor out Eth bridge activation status predicates
  Test comptime disabled Ethereum bridge
  Configure the status of the Eth bridge at comptime
@tzemanovic tzemanovic merged commit 41771f5 into main Apr 12, 2024
14 of 17 checks passed
@tzemanovic tzemanovic deleted the tiago/comptime-eth-bridge branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Ethereum Bridge code Check if Bridge is disabled to reject tx in Bridge pool VP
4 participants