-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Ethereum Bridge functionality at compile time #2602
Conversation
e5fc9b8
to
888a29a
Compare
it would be good to add the feature to |
I left it out of this PR on purpose. Figured we won't be enabling the Bridge any time soon, anyway. I can add it to the manifest files, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to still run the unit tests with bridge enabled in the ci. Otherwise they won't be maintained and will rot and potentially be a big headache later.
888a29a
to
129c8dd
Compare
129c8dd
to
ff2b495
Compare
ff2b495
to
f88941e
Compare
f88941e
to
7c9f10c
Compare
added a CI task to run eth bridge tests |
7c9f10c
to
8868e1c
Compare
8868e1c
to
636ef54
Compare
636ef54
to
21f4c3d
Compare
98cbd8d
to
b7cd34a
Compare
b7cd34a
to
c9d0a56
Compare
* origin/tiago/comptime-eth-bridge: Changelog for #2602 Enable Ethereum bridge testing in CI Include Makefile target to test Eth bridge Add `namada-eth-bridge` feature to Cargo manifests Stop benchmarking Ethereum bridge txs and vps Disable Namada Eth bridge CLI cmds Disable and/or adjust Bridge pool VP tests Disable Bridge pool txs Factor out Eth bridge activation status predicates Test comptime disabled Ethereum bridge Configure the status of the Eth bridge at comptime
Describe your changes
Closes #2598
Closes #2027
Indicate on which release or other PRs this topic is based on
v0.31.4
Checklist before merging to
draft