Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Bridge is disabled to reject tx in Bridge pool VP #2027

Closed
Tracked by #2023
sug0 opened this issue Oct 23, 2023 · 2 comments · Fixed by #2602
Closed
Tracked by #2023

Check if Bridge is disabled to reject tx in Bridge pool VP #2027

sug0 opened this issue Oct 23, 2023 · 2 comments · Fixed by #2602
Labels
bug Something isn't working ethereum-bridge prio:low

Comments

@sug0
Copy link
Collaborator

sug0 commented Oct 23, 2023

if the bridge is disabled through a governance vote, the Bridge pool may grow arbitrarily large. the Bridge pool VP should reject txs when the bridge is disabled

@sug0 sug0 added bug Something isn't working ethereum-bridge labels Oct 23, 2023
@sug0 sug0 added the prio:high label Oct 23, 2023
@Kofituo
Copy link
Contributor

Kofituo commented Jan 12, 2024

@sug0 @brentstone @tzemanovic
Hello, I'd like to contribute to this project and I'd like to address this issue. May I know how to go about this issue, for instance the relevant lines of code involved?

@sug0 sug0 added prio:low and removed prio:high labels Jan 12, 2024
@sug0
Copy link
Collaborator Author

sug0 commented Jan 12, 2024

@Kofituo The patch is relatively simple: you need to hook up a condition to shared/src/ledger/native_vp/ethereum_bridge/bridge_pool_vp.rs, which is where the Bridge pool VP lives, rejecting transactions if the Ethereum Bridge is disabled. Look in ethereum_bridge/src/storage/eth_bridge_queries.rs to determine how to test if the Bridge is disabled or not.

nodersteam pushed a commit to nodersteam/namada that referenced this issue Jan 15, 2024
This reverts commit 96dd652.
nodersteam pushed a commit to nodersteam/namada that referenced this issue Jan 15, 2024
This reverts commit 96dd652.
nodersteam pushed a commit to nodersteam/namada that referenced this issue Jan 15, 2024
This reverts commit 96dd652.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ethereum-bridge prio:low
Projects
None yet
2 participants