Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict to 1 validator slash per block height #2574

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Feb 9, 2024

Describe your changes

Closes #2567.

Indicate on which release or other PRs this topic is based on

v0.31.9

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone added the PoS label Feb 9, 2024
@brentstone brentstone force-pushed the brent/improve-slash-queue branch from 0d3ca88 to 4af24b3 Compare February 11, 2024 04:10
@brentstone brentstone force-pushed the brent/improve-slash-queue branch 2 times, most recently from 3d39c84 to 22b3312 Compare February 28, 2024 06:25
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.88%. Comparing base (2ba001d) to head (a4fc64d).
Report is 131 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
- Coverage   53.88%   53.88%   -0.01%     
==========================================
  Files         308      308              
  Lines      100154   100161       +7     
==========================================
+ Hits        53966    53967       +1     
- Misses      46188    46194       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/improve-slash-queue branch from 22b3312 to bc55bd6 Compare March 3, 2024 10:23
brentstone added a commit that referenced this pull request Mar 3, 2024
@brentstone brentstone force-pushed the brent/improve-slash-queue branch from 4e02bda to a4fc64d Compare March 8, 2024 08:40
@brentstone brentstone requested a review from tzemanovic March 8, 2024 08:41
@brentstone brentstone marked this pull request as ready for review March 8, 2024 08:42
tzemanovic added a commit that referenced this pull request Mar 19, 2024
* origin/brent/improve-slash-queue:
  test
  refactor: drop the LazyVec
  changelog: add #2574
  fix testing
  ensure that only 1 slash per block is enqueued
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/brent/improve-slash-queue:
  test
  refactor: drop the LazyVec
  changelog: add #2574
  fix testing
  ensure that only 1 slash per block is enqueued
@brentstone brentstone mentioned this pull request Apr 11, 2024
1 task
@tzemanovic tzemanovic merged commit 9376270 into main Apr 12, 2024
17 checks passed
@tzemanovic tzemanovic deleted the brent/improve-slash-queue branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict allowed slashes for a validator to 1 per block height
2 participants