Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict allowed slashes for a validator to 1 per block height #2567

Closed
Tracked by #2530
brentstone opened this issue Feb 8, 2024 · 0 comments · Fixed by #2574
Closed
Tracked by #2530

Restrict allowed slashes for a validator to 1 per block height #2567

brentstone opened this issue Feb 8, 2024 · 0 comments · Fixed by #2574
Assignees
Labels

Comments

@brentstone
Copy link
Collaborator

We should probably only processes a single slash per block height for a given validator.

Upon revival of the SE2 net, several validators were caught for misbehaving, and in almost all cases, the protocol has enqueued multiple slashes all at the same block height for seemingly the same single misbehavior. Here's an excerpt from the namadac slashes logs:

Enqueued slashes for future processing

To be processed in epoch 6
Infraction epoch 0, block height 5, type Duplicate vote, validator tnam1qxdlvt04892jx2m5y3dsqagrlh5grreuqgfmtftm
Infraction epoch 0, block height 5, type Duplicate vote, validator tnam1qxdlvt04892jx2m5y3dsqagrlh5grreuqgfmtftm
Infraction epoch 0, block height 5, type Duplicate vote, validator tnam1qxdlvt04892jx2m5y3dsqagrlh5grreuqgfmtftm
Infraction epoch 0, block height 5, type Duplicate vote, validator tnam1qxdlvt04892jx2m5y3dsqagrlh5grreuqgfmtftm
Infraction epoch 0, block height 5, type Duplicate vote, validator tnam1qxdlvt04892jx2m5y3dsqagrlh5grreuqgfmtftm

To be processed in epoch 6
Infraction epoch 0, block height 5, type Duplicate vote, validator tnam1q84tqxcm0l792cvtx8ufe6erx00fwwjtggv925l4
Infraction epoch 0, block height 5, type Duplicate vote, validator tnam1q84tqxcm0l792cvtx8ufe6erx00fwwjtggv925l4
Infraction epoch 0, block height 5, type Duplicate vote, validator tnam1q84tqxcm0l792cvtx8ufe6erx00fwwjtggv925l4

It doesn't make much sense to account for all of these infractions in computing their cubic slash rates. I think we should de-duplicate such instances before enqueueing the slashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant