Fix the Ethereum Bridge VP #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ERC20 transfer checks from the Ethereum bridge native VP. Now, the only checks performed by this VP are that NAM was escrowed correctly under the Ethereum bridge address, and that no keys other than balance keys under this address can be modified.
This was referenced Aug 29, 2023
Closed
sug0
added a commit
that referenced
this pull request
Aug 30, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/fix-ethbridge-vp: Changelog for #1855 Allow an arbitrary nr of accounts to transfer to the Eth bridge addr Refactor the Ethereum bridge native VP Introduce `has_eth_addr_segment()` storage key predicate
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/fix-ethbridge-vp: Changelog for #1855 Allow an arbitrary nr of accounts to transfer to the Eth bridge addr Refactor the Ethereum bridge native VP Introduce `has_eth_addr_segment()` storage key predicate
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/fix-ethbridge-vp: Changelog for #1855 Allow an arbitrary nr of accounts to transfer to the Eth bridge addr Refactor the Ethereum bridge native VP Introduce `has_eth_addr_segment()` storage key predicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The Ethereum Bridge VP should not check ERC20 transfers anymore. This is the job of the Multitoken native VP. Its job should be solely to check the escrow of NAM under its internal address, and that users do not attempt to modify Ethereum event tallies.
NOTE: Change the base to
mainonce reviewed.Indicate on which release or other PRs this topic is based on
#1854
Checklist before merging to
draft