HOTFIX: Trigger the NUT VP #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yito88
reviewed
Aug 29, 2023
Comment on lines
+478
to
+480
| // TODO: this should not be a special case, as it is error prone. | ||
| // any internal addresses corresponding to tokens which have | ||
| // native vp equivalents should be automatically added as verifiers |
There was a problem hiding this comment.
yeah, we want to skip only actual token addresses.
These insertions into the verifiers could be simpler since token balance keys and minted keys have the Multitoken address if we could recognize these token addresses.
yito88
previously approved these changes
Aug 29, 2023
batconjurer
approved these changes
Aug 31, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/hotfix-trigger-nut-vp: Changelog for #1854 hotfix: Add NUT native VP as a verifier Iterate over all addrs in a storage key
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/hotfix-trigger-nut-vp: Changelog for #1854 hotfix: Add NUT native VP as a verifier Iterate over all addrs in a storage key
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/hotfix-trigger-nut-vp: Changelog for #1854 hotfix: Add NUT native VP as a verifier Iterate over all addrs in a storage key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Crude fix to the NUT VP not being triggered.
NOTE: Change the base to
mainonce reviewed.Indicate on which release or other PRs this topic is based on
#1853
Checklist before merging to
draft