Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/353 - Ledger error-handling improvements #363

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Aug 10, 2023

Resolves #353

Any time an error is encountered with the Ledger device, the extensions should always allow the user to correct the issue and proceed. A locked device or unloaded app should not force the user to refresh! Also, the appropriate error should be reported to user in each case!

  • Connect Ledger
    • Recovers from device locked
    • Recovers from app not loaded
    • Recovers from device not plugged in, or device not initially unlocked (same error: "Access Denied")
  • Add Account
    • Recovers from device locked
    • Recovers from app not loaded
    • Recovers from device not plugged in, or device not initially unlocked (same error: "Access Denied")
  • Reveal PK
    • Does not proceed to next transaction if any errors are encountered (including tx rejection)
  • Submit Tx (Reveal PK, Bond, Unbond, Withdraw, Transfer)
    • Recovers from device locked
    • Recovers from app not loaded
    • Recovers from transaction rejected
    • Recovers from device not plugged in, or device not initially unlocked (same error: "Access Denied")

@jurevans jurevans added bug Something isn't working E - Ledger HW labels Aug 10, 2023
@jurevans jurevans self-assigned this Aug 10, 2023
@jurevans jurevans marked this pull request as draft August 10, 2023 10:44
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 10:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 11:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 11:53 Inactive
@jurevans jurevans marked this pull request as ready for review August 10, 2023 12:22
@jurevans jurevans changed the title WIP: bug/353 - Ledger error-handling improvments bug/353 - Ledger error-handling improvments Aug 10, 2023
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 12:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 11, 2023 10:28 Inactive
@jurevans jurevans force-pushed the bug/353-ledger-error-handling branch from 575687f to 191d411 Compare August 11, 2023 11:25
@github-actions github-actions bot temporarily deployed to pull request August 11, 2023 11:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 11, 2023 12:30 Inactive
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! Looks good to me :)

@jurevans jurevans merged commit aeebba8 into main Aug 11, 2023
5 checks passed
@jurevans jurevans deleted the bug/353-ledger-error-handling branch August 11, 2023 13:46
@jurevans jurevans changed the title bug/353 - Ledger error-handling improvments bug/353 - Ledger error-handling improvements Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ledger Reveal PK TX Rejection/Error does not break flow
2 participants