Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Ledger Reveal PK TX Rejection/Error does not break flow #353

Closed
3 tasks done
jurevans opened this issue Aug 3, 2023 · 0 comments · Fixed by #363
Closed
3 tasks done

[Bug] Ledger Reveal PK TX Rejection/Error does not break flow #353

jurevans opened this issue Aug 3, 2023 · 0 comments · Fixed by #363
Assignees
Labels
bug Something isn't working

Comments

@jurevans
Copy link
Collaborator

jurevans commented Aug 3, 2023

When the user submits a transaction using a Ledger account for the first time, they are required to approve and submit a "reveal PK" transaction. Currently, it is not handled if the user rejects that transaction, and following rejection will immediately try to execute the original transaction, which shouldn't happen.

  • If user rejects a Reveal PK, it should break out of the flow, and reset, displaying the rejection response to the user
  • If an error occurs (such as if the device is locked), this should also break that flow correctly (it will currently break the flow, but clicking "Try Again" does not hit the reveal PK step again successfully, meaning if the following tx is attempted, it will fail on chain)
  • Look into handling errors such as when the App itself is not loaded and thus the JS client is unable to initialize. Take a look at the LedgerErrors enum, and compare the results of the status query in each of these cases so we can handle them appropriately

This may take a little bit of time to determine the best way to handle all potential Ledger states, and could potentially be improved across the board.

@jurevans jurevans added bug Something isn't working Extension UI labels Aug 3, 2023
@jurevans jurevans added this to the Release 1.0 (Q4 2022) milestone Aug 3, 2023
@jurevans jurevans self-assigned this Aug 3, 2023
@jurevans jurevans changed the title [Bug] Ledger Reveal PK TX Rejection does not break flow [Bug] Ledger Reveal PK TX Rejection/Error does not break flow Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Tested in Devnet
Development

Successfully merging a pull request may close this issue.

1 participant